Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission: deploy-rs (open source contribution) #1363

Merged
merged 1 commit into from
May 3, 2021

Conversation

ysndr
Copy link

@ysndr ysndr commented Apr 26, 2021

Submission on proposal #1047
Implementing feature request #60 at deploy-rs.

Self-assessment based on the courses guidelines:

Yes Remarkable
The contribution fixes bugs Yes
The contribution improves documentation Yes
The contribution adds new features Yes hard features
The contribution is much appreciated by the community Requested by the community

@ysndr
Copy link
Author

ysndr commented Apr 26, 2021

The maintainer of the project, although helpful at the beginning, did not yet respond to our request to merge the PR.

@ysndr
Copy link
Author

ysndr commented Apr 26, 2021

Pinging the responsible TA @cesarsotovalero

@SophieHYe
Copy link

Hi,
Cesar is on holiday. Your PR looks great. I am merging your PR now.

@SophieHYe SophieHYe requested a review from cesarsotovalero May 3, 2021 05:55
@SophieHYe SophieHYe merged commit 80a8a15 into KTH:2021 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants