Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Submission] Feedback on essay Feedback Automated tests for infrastructure code #1415 #1335

Merged
merged 18 commits into from
May 5, 2021

Conversation

fbjorkman
Copy link

Here is the feedback on your essay! I hope it helps :) @amarhod

@SophieHYe
Copy link

Hi,
Thanks for the feedback. Could you please 1) solve the conflicting files and 2) add the final PR of the essay submission(#999 was the initial, not the final). Thanks.

@SophieHYe SophieHYe self-assigned this May 3, 2021
@github-actions github-actions bot added essay One of the task categories listed in README.md feedback final_submission The final submission of a task labels May 4, 2021
@github-actions
Copy link

github-actions bot commented May 4, 2021

The ID:s constituting the folder name matched with the email addresses in the README file.
The group consisting of fbjorkma, appears to have worked together 1 times.
Maximum group size allowed: 3.
Maximum number of collaborations allowed: 2.
The group composition is allowed.

@fbjorkman fbjorkman changed the title [Submission] Feedback on essay Feedback Automated tests for infrastructure code #999 [Submission] Feedback on essay Feedback Automated tests for infrastructure code #1415 May 4, 2021
Added the final submission PR on the essay
@github-actions
Copy link

github-actions bot commented May 4, 2021

The ID:s constituting the folder name matched with the email addresses in the README file.
The group consisting of fbjorkma, appears to have worked together 1 times.
Maximum group size allowed: 3.
Maximum number of collaborations allowed: 2.
The group composition is allowed.

@github-actions
Copy link

github-actions bot commented May 4, 2021

There wasn't exactly one readme added under "contributions/" . This is assumed not to be a student project proposal.

@fbjorkman
Copy link
Author

@SophieHYe The merge conflict have been solved and I have added the PR for the final essay PR submission and also changed the title of this PR to the correct PR number

@SophieHYe
Copy link

Thanks for the update. I am merging your PR.

@SophieHYe SophieHYe merged commit 8830f04 into KTH:2021 May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
essay One of the task categories listed in README.md feedback final_submission The final submission of a task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants