Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ConfigNode load/save perf #88

Merged
merged 8 commits into from
Aug 26, 2022
Merged

Improve ConfigNode load/save perf #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
55d6bd0
Rewrite PreFormatConfig to iterate through strings as little as possi…
NathanKell Aug 25, 2022
e198485
Improve logging, add @siimav's parallel processing bit (seems to be s…
NathanKell Aug 25, 2022
e4ffba6
Patch writing, too, for a slight improvement in perf
NathanKell Aug 25, 2022
522f4fe
Fix a lingering issue with trailing braces
NathanKell Aug 25, 2022
3e1fa2a
Patch on startup, not after MM. Skipping keys will only happen after …
NathanKell Aug 25, 2022
fbca6ab
Update readme and Settings
NathanKell Aug 25, 2022
de625a5
Big improvements to save perf by not writing lines / flushing / using…
NathanKell Aug 26, 2022
1062b39
missed a newline
NathanKell Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions GameData/KSPCommunityFixes/Settings.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,18 @@ KSP_COMMUNITY_FIXES
// and every time you delete a vessel in the Tracking Station
FewerSaves = false

// These settings will make ConfigNode's loader not bother doing
// Extended checking during parsing for keys named ths
CONFIGNODE_PERF_SKIP_PROCESSING_KEYS
{
item = serialized_plugin
}
// or for keys that start with this.
CONFIGNODE_PERF_SKIP_PROCESSING_SUBSTRINGS
{
item = **skipProc**
}

// ##########################
// Modding
// ##########################
Expand Down
1 change: 1 addition & 0 deletions KSPCommunityFixes/KSPCommunityFixes.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@
<Compile Include="Modding\OnSymmetryFieldChanged.cs" />
<Compile Include="Modding\ReflectionTypeLoadExceptionHandler.cs" />
<Compile Include="Performance\FewerSaves.cs" />
<Compile Include="Performance\ConfigNodePerf.cs" />
<Compile Include="Performance\PQSCoroutineLeak.cs" />
<Compile Include="Performance\PQSUpdateNoMemoryAlloc.cs" />
<Compile Include="Performance\ProgressTrackingSpeedBoost.cs" />
Expand Down
Loading