Faster FindModelTransform*() and FindHeirarchyTransform*()
#255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orm* and FindHeirarchyTransform* methods. Roughly 4 times faster on average for callers in a stock install, but this can go up to 20x faster on deep hierarchies.
gotmachine
changed the title
FindModelTransform*() and vFindHeirarchyTransform*()`FindModelTransform*() and FindHeirarchyTransform*()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faster, and minimal GC alloc relacements for the Part FindModelTransform* and FindHeirarchyTransform* methods.
Roughly 4 times faster on average for callers in a stock install, but this can go up to 20x faster on deep hierarchies.
The main trick is to use
Transform.Find()instead of checking theTransform.nameproperty (which will allocate a new string) for every transform in the hierarchy. There are a few quirks withTransform.Find()requiring additional care, but this is overall much faster and eliminate GC allocations almost entirely.Even though they are mostly "init-time" methods, they are used quite a bit in stock, and massively over the modding ecosystem, so this can help with loading time and scene switches : https://github.com/search?q=FindModelTransform+OR+FindModelTransforms+language%3AC%23&type=code