-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RoboticsDrift doesn't work with model hierarchies having a position/rotation offset #35
Labels
bug
Something isn't working
Comments
gotmachine
pushed a commit
that referenced
this issue
May 8, 2022
…o parts having `MODEL{}` rotation/position offsets and/or a model hierarchy where the rotation transform has a position/rotation offset relative to the model root. Notably fixes incorrect behavior with the BDB [Hokulani OCO-RT90 Truss Structure](https://forum.kerbalspaceprogram.com/index.php?/topic/122020-1123-bluedog-design-bureau-stockalike-saturn-apollo-and-more-v1101-%D0%BB%D1%83%D0%BD%D0%B0-24apr2022/&do=findComment&comment=4128194).
gotmachine
added a commit
that referenced
this issue
May 8, 2022
…ock servo parts having `MODEL{}` rotation/position offsets and/or a model hierarchy where the rotation transform has a position/rotation offset relative to the model root. Notably fixes incorrect behavior with the BDB [Hokulani OCO-RT90 Truss Structure](https://forum.kerbalspaceprogram.com/index.php?/topic/122020-1123-bluedog-design-bureau-stockalike-saturn-apollo-and-more-v1101-%D0%BB%D1%83%D0%BD%D0%B0-24apr2022/&do=findComment&comment=4128194)." This reverts commit 65febd3.
gotmachine
added a commit
that referenced
this issue
May 8, 2022
…o parts having `MODEL{}` rotation/position offsets and/or a model hierarchy where the rotation transform has a position/rotation offset relative to the model root. Notably fixes incorrect behavior with the BDB [Hokulani OCO-RT90 Truss Structure](https://forum.kerbalspaceprogram.com/index.php?/topic/122020-1123-bluedog-design-bureau-stockalike-saturn-apollo-and-more-v1101-%D0%BB%D1%83%D0%BD%D0%B0-24apr2022/&do=findComment&comment=4128194).
gotmachine
added a commit
that referenced
this issue
May 15, 2022
…d parts of translation servos following the fix for issue #35 released in KSPCF 1.12.2 (see [report 1](https://forum.kerbalspaceprogram.com/index.php?/topic/204002-18-112-kspcommunityfixes-bugfixes-and-qol-tweaks/&do=findComment&comment=4132262), [report 2](#13 (comment)))
gotmachine
added a commit
that referenced
this issue
Jan 30, 2023
…o parts having `MODEL{}` rotation/position offsets and/or a model hierarchy where the rotation transform has a position/rotation offset relative to the model root. Notably fixes incorrect behavior with the BDB [Hokulani OCO-RT90 Truss Structure](https://forum.kerbalspaceprogram.com/index.php?/topic/122020-1123-bluedog-design-bureau-stockalike-saturn-apollo-and-more-v1101-%D0%BB%D1%83%D0%BD%D0%B0-24apr2022/&do=findComment&comment=4128194).
gotmachine
added a commit
that referenced
this issue
Jan 30, 2023
…d parts of translation servos following the fix for issue #35 released in KSPCF 1.12.2 (see [report 1](https://forum.kerbalspaceprogram.com/index.php?/topic/204002-18-112-kspcommunityfixes-bugfixes-and-qol-tweaks/&do=findComment&comment=4132262), [report 2](#13 (comment)))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All the stock robotics parts have a model hierarchy where the
movingTransform
(defined byservoTransformName
in configs) has a zero position and rotation relative to the model root.But this doesn't necessarily hold true for modded parts. The model hierarchy can have local pos/rot offsets, and the model itself can be translated/rotated relative to the part transform by defining a non-zero
position
/rotation
in the part configMODEL{}
node.Failing to handle that case causes the
orgRot
/orgPos
update to produce garbage results, resulting in wrong part positions when timewarping and after reloading a saved vessel. This can be seen in the BDB Hokulani OCO-RT90 Truss Structure. That part is victim of both issues, as it uses aMODEL{}
rotation and has local position offsets between the model root and themovingTransform
.We need to fix things in 2 separate places. The position offset should likely be used when calling
RecurseChildCoordsUpdate()
the first time :KSPCommunityFixes/KSPCommunityFixes/BugFixes/RoboticsDrift.cs
Line 442 in 5e6be5a
The rotation offset should likely be accounted for at the
GetLocalToVesselSpace()
level :KSPCommunityFixes/KSPCommunityFixes/BugFixes/RoboticsDrift.cs
Lines 318 to 323 in 5e6be5a
The text was updated successfully, but these errors were encountered: