Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Raptor and RVac MECs #2991

Merged
merged 5 commits into from
Aug 11, 2024
Merged

New Raptor and RVac MECs #2991

merged 5 commits into from
Aug 11, 2024

Conversation

SkyPhoenix999
Copy link
Contributor

  • Updated Specs for Raptor
  • Split off RVac into separate Config
  • Changed to support Raptor 1, Raptor 2, and Raptor 3.

@SkyPhoenix999
Copy link
Contributor Author

Note: TestFlight Configs need work

@SkyPhoenix999
New Raptor and RVac MEC
f0ee1b5 
- Updated Specs for Raptor
- Split off RVac into separate Config
- Changed to support Raptor 1, Raptor 2, and Raptor 3.
@SkyPhoenix999
Copy link
Contributor Author

Requires Subcooled Methane Pull to work

Capkirk123
Capkirk123 requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@Capkirk123 Capkirk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No spaces in config names, it makes them a lot harder to patch and messes with RP-1

SkyPhoenix999 and others added 3 commits August 5, 2024 21:38
@SkyPhoenix999
Changed Spaces to Dashes
210b122 
Changed Spaces to Dashes because RP-1 hates spaces
@SkyPhoenix999
Borked Link
861ff05
@SkyPhoenix999
Also a Borked Link
29e2241
@SkyPhoenix999
Copy link
Contributor Author

No spaces in config names, it makes them a lot harder to patch and messes with RP-1

Added Dashes to all config names instead of spaces

Capkirk123
Capkirk123 requested changes Aug 11, 2024
View reviewed changes
Copy link
Member

@Capkirk123 Capkirk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to alter the Cryoengines configs in this PR?

@Capkirk123
Copy link
Member

resolves #2995

@Capkirk123 Capkirk123 linked an issue Aug 11, 2024 that may be closed by this pull request
raptor engine update #2995
Closed
@SkyPhoenix999
Copy link
Contributor Author

I didn't originally intend to but I already had the configs for it for testing, so it's just one less PR that needs to be made

@Capkirk123 Capkirk123 merged commit 49790c6 into KSP-RO:master Aug 11, 2024
3 checks passed
@Capkirk123 Capkirk123 mentioned this pull request Aug 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Capkirk123 Capkirk123 Capkirk123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

raptor engine update
2 participants
@SkyPhoenix999 @Capkirk123