Add RD-0108, improve RD-0110 configs #2909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
|
Yay!! :) One thing--if the 0106 is the same as the 0107, why do both configs exist rather than (I think we do this elsewhere?) combining them? |
Since the RD-0106 is functionally identical to the 0107, just disable it.
|
I don't see why not |
|
rp-1 was making 0106 unlock later but be cheaper: https://github.com/KSP-RO/RP-1/blob/ceec61b4557351f9e0adeaefc16dfae56e277968/Source/Tech%20Tree/Parts%20Browser/data/Engine_Config.json#L9836 can't speak to whether that was just nonsense (or to what the engine recosting has to say about it) |
|
RD-0106 did fly later than the RD-0107. But since they were identical other than mounting, I don't really see any point to keeping it around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RD-0108 config, a more reliable, man-rated version of the RD-0107. Also adjust RD-0106 config to be the same as the RD-0107, give 107% throttle to RD-0110, and decrease mass of all RD-0110 variants