Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RP-1 Contract Satellites #2249

Merged
merged 1 commit into from
Sep 24, 2023
Merged

RP-1 Contract Satellites #2249

merged 1 commit into from
Sep 24, 2023

Conversation

ryanc55
Copy link
Contributor

@ryanc55 ryanc55 commented Sep 24, 2023

Remove Nav/Com/Weather payloads from SM tanks. Introduce custom RP-1 payload satellites for NavSatPayload and ComSatPayload.
Supported by KSP-RO/ROLibrary#24

Remove Nav/Com/Weather payloads from SM tanks. Introduce custom RP-1 payload satellites for NavSatPayload and ComSatPayload.
@NathanKell NathanKell merged commit ac43f5d into KSP-RO:master Sep 24, 2023
3 checks passed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just popping in because I'm curious about this. Why would you replace the payload for the weather sat contract with navsat payload? Have I misinterpreted this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there are two lines of models, so there have to be 2 resources. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh... I'm not really sure what that means. Do you mind explaining that to an idiot?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This PR adds a part that contains ComSatPayload and a set of models for that part
  2. This PR adds a part that contains NavSatPayload and a set of models for that part
  3. We had 3 sat payload resources.
  4. There are now only two supported ways put resources on your craft: one that puts ComSatPayload on (1) and one that puts NavSatPayload on (2)
  5. So we need to have only 2 payload resources in contracts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok that makes sense, thank you. How come we don't have a part for weather sat though? Is it really that similar to navsat payload?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a practical matter. There was only one non-repeatable weather sat contract and making new models is time consuming. We specifically wanted to have dedicated parts and models for each payload type, with several tech looks to choose from. Weather sats may reappear in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants