Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSP2 netkan validation #91

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Mar 11, 2023

Motivation

As we advance toward the finish line of KSP2 support, we are getting closer to the point where we will need to be able to validate, review, and merge KSP2-NetKAN pull requests. This will require updating xKAN-meta_testing to support the new game.

Problem

Only KSP1 support exists for:

  • Retrieving known game versions from GitHub
  • Creating a dummy game instance
  • Inflating .netkans
  • Validating .ckans

Changes

Now the Action has a game parameter, defaulting to KSP, which allows the configuration file to specify how to get game versions and the value of the --game parameter for netkan.exe and ckan instance fake commands. This is done by creating a new Game abstract base class with derived classes Ksp1 and Ksp2, which provide public properties specifying their short names and their known game versions. Code that needs these values is updated to get them from Game objects that are now deduced from the GAME environment variable and then passed around.

In the process of making these changes, the validator is now switched from retrieving the embedded build map, which has been renamed to builds-ksp.json in KSP-CKAN/CKAN#3797, to using the remote build maps, which are not subject to naming collisions because they're in separate repos.

@HebaruSan
Copy link
Member Author

Let's see if this works...

Copy link
Member

@techman83 techman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks pretty reasonable 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants