Remove spec_version from all netkans #10166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That was interesting. Since the download cache size limit is set per game instance, and inflation occurs before any game instances are created, there is effectively no download cache size limit for the inflation step. Which means that it will reliably fill the disk after enough modules are inflated. Furthermore, we don't know the size of the download before we download it! So even if a limit was defined, there would be no way to know how much space is needed before each inflation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of KSP-CKAN/CKAN#4155,
spec_versionis now optional and auto-generated by the inflator. KSP-CKAN/NetKAN-Infra#336 and KSP-CKAN/metadata-webtool#49 have removed code that added it to machine-generated netkans, and it has been removed from https://github.com/KSP-CKAN/CKAN/wiki/Adding-a-mod-to-the-CKAN.Now all existing netkans have
spec_versionremoved. Since this is almost every file in this repo, it will also be a sort of stress test of the metadata tester.