Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formal client specification. #961

Closed
wants to merge 2 commits into from
Closed

Formal client specification. #961

wants to merge 2 commits into from

Conversation

Ippo343
Copy link
Contributor

@Ippo343 Ippo343 commented May 26, 2015

This pull requests aims to implement a formal specification for the behaviour of ckan clients.
See also issue #956.

@Ippo343
Copy link
Contributor Author

Ippo343 commented May 26, 2015

Current state: I wrote a starting point for v1 specification.
For the moment I am only working on version 1 of the specification: once we will have discussed and accepted version 1 (which is by far the biggest part of the work), I will work on supplementing it with subsequent extensions.

Please see the line comments for the parts where I would need some feedback.


The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in [RFC 2119](http://www.faqs.org/rfcs/rfc2119.html).


Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Introducing the definitions for some of the terms using further down.

If a `filter` field is specified,
it contains one or more files that must be excluded from the installation
even if they are selected by the corresponding `file` field.
The `filter` field only affects files in the same install stanza
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filter field also affects folders in the same install stanza, or is that somehow included in files? Wasn't obvious to me so thought I'd point it out.

@pjf
Copy link
Member

pjf commented Dec 13, 2015

@Ippo343 : I'm looking to close out old PRs, and I'm not exactly sure what to do with this one. If you're still looking at building a Python core then I'm happy to review and comment, although in terms of ongoing maintenance I feel that integrating this into the existing metadata spec would ensure it continues to be updated going forward.

Alternatively, if you're happy to close this out, then that's one step closer to my goal of PR-box zero. :)

the client must exclude from the installation
all the files that match one or more of the listed regular expressions.

### File overwriting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to remove this section. Issues like #1311 show that we have thought about (and generally support) a limited method for overwriting so I don't see why we would impose this restriction on others.

@Ippo343
Copy link
Contributor Author

Ippo343 commented Dec 13, 2015

Hey Paul, I've moved on to other things, so (sadly) I don't think I will continue with the python client. This can be closed safely.


Da: Paul Fenwickmailto:notifications@github.com
Inviato: ‎13/‎12/‎2015 07:18
A: KSP-CKAN/CKANmailto:CKAN@noreply.github.com
Cc: Michelemailto:m.ippolito@outlook.com
Oggetto: Re: [CKAN] Formal client specification. (#961)

@Ippo343 : I'm looking to close out old PRs, and I'm not exactly sure what to do with this one. If you're still looking at building a Python core then I'm happy to review and comment, although in terms of ongoing maintenance I feel that integrating this into the existing metadata spec would ensure it continues to be updated going forward.

Alternatively, if you're happy to close this out, then that's one step closer to my goal of PR-box zero. :)


Reply to this email directly or view it on GitHub:
#961 (comment)

@pjf
Copy link
Member

pjf commented Dec 13, 2015

Hey Paul, I've moved on to other things, so (sadly) I don't think I will continue with the python client.

This is code for "being an awesome guitarist", yes? :)

This can be closed safely.

Roger that! One step closer to PR-box zero!

P.S. You're amazing!

@pjf pjf closed this Dec 13, 2015
@pjf pjf removed the pull request label Dec 13, 2015
@Ippo343
Copy link
Contributor Author

Ippo343 commented Dec 13, 2015

This is code for "being an awesome guitarist", yes? :)

AND skydiver AND cook :P And watch out next year for the paragliding course ;)

P.S. You're amazing!

Nah, I just have a good role model to follow, that being you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants