Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inflation error for multi-hosted mods with mismatched versions #4178

Merged

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Sep 8, 2024

Motivation

Authors of multi-hosted mods don't always upload the same versions to all hosts. Currently this results in an Out-of-order version found on unreliable server error (about 8 of these are active currently); this message does not accurately report what the actual problem is, and it's possible for a partially-inflated mod to be indexed first.

Changes

Now if we get more modules than requested, an inflation error is thrown that describes which versions were found on which hosts:

$ netkan.exe NetKAN/ZTheme.netkan --releases 3
6461 [1] FATAL CKAN.NetKAN.Program (null) - Generated 4 modules but only 3 requested: v1.1.3.1 on github.com; v1.1.3 on github.com, spacedock.info; v1.1.2 on github.com, spacedock.info; v1.1.1 on spacedock.info

@HebaruSan HebaruSan added Enhancement New features or functionality Easy This is easy to fix Netkan Issues affecting the netkan data labels Sep 8, 2024
@HebaruSan HebaruSan merged commit 3992aa0 into KSP-CKAN:master Sep 8, 2024
3 checks passed
@HebaruSan HebaruSan deleted the feature/multi-host-mistmach-error branch September 8, 2024 15:51
@HebaruSan
Copy link
Member Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix Enhancement New features or functionality Netkan Issues affecting the netkan data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant