Update Signpath Action #4162
Merged
Update Signpath Action #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release version is now available for signpath, though there are still a couple of steps to go through, this will ensure signing is working correctly with the release action. #1354
HebaruSan
added
Enhancement
HebaruSan
approved these changes
Aug 18, 2024
There was a problem hiding this comment.
Exciting to get closer to the finish line!
Could we move this value to a secret? I know it's not technically "secret" per se in the sense of being sensitive, but if we want to change it at some point in the future, updating a value in the repo's secrets seems like a better way than editing the workflow.
organization-id: 0cd9fc3f-b78d-4214-b152-b2e93c952e14
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release version is now available for signpath, though there are still a couple of steps to go through, this will ensure signing is working correctly with the release action.