Allow string "Harmony" in DLL parent folder names #4123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CelestialHarmonyhas been having spurious inflation errors for a bit over a week.Cause
The guardrail to catch bundled copies of the Harmony DLL from #3326 checks the entire file path, not just the file name, so a folder with a name coincidentally containing the string "Harmony" will cause a false positive if it contains a DLL.
Changes
Now this check only looks for "Harmony" in the filename by starting the search at
Math.Max(0, f.LastIndexOf('/')).