Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default transaction timeout #4119

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix default transaction timeout #4119

merged 1 commit into from
Jul 9, 2024

Conversation

romi2002
Copy link
Contributor

@romi2002 romi2002 commented Jul 9, 2024 •
edited by HebaruSan
Loading

Fixes GameInstance scanning described in #3770, switching over to a default timeout value of Int32.MaxValue.

Fixes #3770.

@HebaruSan HebaruSan added Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN macOS Issues specific for macOS Mono Issues specific for Mono labels Jul 9, 2024
@HebaruSan
Copy link
Member

Thanks! That makes sense. I must have assumed that Int32.MaxValue was equal to the value we had there without looking it up, but I guess one is signed and the other is unsigned.

Hey @ofbakirci or @jfinkbei or anyone else having the issue from #3770, would you mind trying out this PR's build and confirming whether that issue is fixed?

For posterity, it looks like the new max value is now ~25 days, down from the 49 days documented in #3512.

@romi2002
Copy link
Contributor Author

romi2002 commented Jul 9, 2024

I was getting a similar issue as the one @jfinkbei was getting in #3770 on Arch Linux, and CKAN was hanging on game instance scanning. This PR seems to have fixed it for me.

HebaruSan
HebaruSan approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@HebaruSan HebaruSan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @romi2002! I just wanted to make sure this had been stress tested to catch any unknown unknowns.

@HebaruSan HebaruSan merged commit ab683b7 into KSP-CKAN:master Jul 9, 2024
3 checks passed
This was referenced Jul 9, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HebaruSan HebaruSan HebaruSan approved these changes

Assignees
No one assigned
Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN macOS Issues specific for macOS Mono Issues specific for Mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Transaction failed during GameInstance.Scan on Mac
2 participants
@romi2002 @HebaruSan