Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated client message when up to date #4057

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Mar 14, 2024

Problem

The new "Repositories updated, but found modules that require a new version of CKAN. Checking for updates..." message appears on every update, regardless of whether your client is outdated.

Cause

In #4026 we treated an ArchiveEntry tuple as indicating an unsupported spec version if its first item was null, but this is also expected for download_counts.json, builds.json, and repositories.json. The correct indicator is when all of the first four items are null.

Changes

Now we check whether all of the first four items in the tuple are null.

@HebaruSan HebaruSan added Bug Something is not working as intended Easy This is easy to fix GUI Issues affecting the interactive GUI Core (ckan.dll) Issues affecting the core part of CKAN labels Mar 14, 2024
@HebaruSan HebaruSan merged commit 98b76fb into KSP-CKAN:master Mar 14, 2024
8 checks passed
@HebaruSan HebaruSan deleted the fix/upgrade-at-update branch March 14, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant