Dutch translation and icon duplication guardrails #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Enhancement
HebaruSan
force-pushed
the
feature/dutch
branch
5 times, most recently
from
ebc02e6
to
75f5f87
Compare
HebaruSan
force-pushed
the
feature/dutch
branch
from
75f5f87
to
9834083
Compare
techman83
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
@TundraMods has graciously started working on a Dutch translation!
https://crowdin.com/project/ckan/nl
Changes
nl-NL) is added and can be extended as more Dutch strings are addedResourcesTestsin the GUI tests folder is updated to loop over all the resources of all the translation DLLs and check that every resource is a string. If the icons get duplicated, they will beBitmaps and the test will fail. To make this work, some unneededboolresources are removed.