Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing resource string for upgrading #3873

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

HebaruSan
Copy link
Member

Problem

I just noticed that the ModuleInstallerUpgradeInstallingResuming resource is declared (there's a property for it) and used but not defined (there's no actual text for it). This is used when you upgrade a module which has a new dependency that you don't have installed yet but which you have a partial download for sitting in your cache. (A quite rare scenario, which probably explains why we haven't had complaints about it yet.)

Changes

Now the string is defined for the default locale as * Install: {0} {1} ({2}, {3} remaining).

@HebaruSan HebaruSan added Bug Something is not working as intended Easy This is easy to fix Core (ckan.dll) Issues affecting the core part of CKAN i18n Issues regarding the internationalization of CKAN and PRs that need translating labels Jul 28, 2023
@HebaruSan HebaruSan requested a review from techman83 July 28, 2023 20:05
@HebaruSan HebaruSan merged commit 2a5a94c into master Jul 30, 2023
10 checks passed
@HebaruSan HebaruSan deleted the fix/missing-upgrade-string branch July 30, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix i18n Issues regarding the internationalization of CKAN and PRs that need translating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants