Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show unmanaged files in game folder #3833

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Apr 27, 2023

Motivation

Twice, users have requested the ability to list the mod files not installed by CKAN:

I have a handful of mods installed manually either because they're betas not in CKAN yet, or other such scenarios.

Checking these mods for updates first requires me to try to identify them from among my predominantly CKAN managed GameData directory.

Sometimes I'll install a mod by hand, a mod not known by CKAN. Then, when doing some cleanup, I may not be sure if a specific directory was installed by CKAN or not, especially when a lot of mods are installed

The goal is to make it easier to figure out which manually installed mods are present.

Changes

Now a new menu option opens a new Unmanaged Files tab, showing a file/folder tree for the current instance's game folder, excluding known stock game folders (like KSP_x64_Data and PDLauncher) and excluding files installed by CKAN. The default view expands the game's primary mod folder (GameData for KSP1, BepInEx/plugins for KSP2) and collapses all others.

image

image

The new toolbar button icons are ugly and do not match the old ones, but I do not know where those old ones came from (it wasn't documented when they were added), and I don't have the ability to create my own. Think of the toolbar as a functional framework to be filled in with better content if a graphic designer contributes some. They are either from Material Icons (Apache-2.0 license), or "free for commercial use":

Fixes #2045.
Fixes #3757 (duplicate).

@hrobertson and @linuxgurugamer, if you have time, please download the test build from the Checks tab's Artifacts dropdown, try it out, and let us know if it works for you.

@HebaruSan HebaruSan added Enhancement New features or functionality GUI Issues affecting the interactive GUI Core (ckan.dll) Issues affecting the core part of CKAN i18n Issues regarding the internationalization of CKAN and PRs that need translating labels Apr 27, 2023
Copy link
Member

@techman83 techman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a super neat feature! Nothing stands out, so LGTM! 😀

@HebaruSan HebaruSan merged commit 3438c3b into KSP-CKAN:master Apr 28, 2023
@HebaruSan HebaruSan deleted the feature/unmanaged-files-tab branch April 28, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating
Projects
None yet
2 participants