Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red highlight for dependencies on missing DLC #3698

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Nov 7, 2022

Problem

If a mod depends on a DLC that you don't have installed, the mod will be treated as incompatible with a red stop sign on the relationships tab due to the missing dependency (since CKAN can't install DLC even if there's a version of it that's compatible with your game version). But if you look at the relationships tab of mod info to try to figure out why it's incompatible, there's no indication that this is the reason:

image

Changes

Now if a mod depends on a DLC that isn't installed, the relationship will be highlighted red, just like for an incompatible dependency:

image

@HebaruSan HebaruSan added Enhancement New features or functionality Easy This is easy to fix GUI Issues affecting the interactive GUI Pull request Relationships Issues affecting depends, recommends, etc. labels Nov 7, 2022
Copy link
Member

@techman83 techman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. The only thing I'll note, there isn't an indicator beyond the colour. Which could be a challenge for those that are colour blind.

@HebaruSan HebaruSan merged commit c4e37d9 into KSP-CKAN:master Nov 14, 2022
@HebaruSan HebaruSan deleted the fix/missing-dlc-red branch November 14, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix Enhancement New features or functionality GUI Issues affecting the interactive GUI Relationships Issues affecting depends, recommends, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants