Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide tray icon at exit via ctrl-C #3639

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Aug 20, 2022

Problems

  • On Windows, the tray icon doesn't disappear at close if you kill CKAN with ctrl-C in the console. (You need to use the --show-console parameter to keep it visible after the GUI appears.) You can even accumulate several of them if you do it over and over:
    image
  • If you use the tray icon to open the settings while CKAN doesn't have focus, it appears at the upper left corner of your monitor
  • Tray icons have the ability to display tooltips, but we don't have one

Changes

  • Now the Console.CancelKeyPress ctrl-C event handler hides the tray icon
  • Now we always pass a reference to the main form when we show the settings dialog, which will ensure it is properly centered on the main window
  • Now the tray icon has a tooltip that says "CKAN"

@HebaruSan HebaruSan added Bug Something is not working as intended Enhancement New features or functionality Easy This is easy to fix GUI Issues affecting the interactive GUI Pull request Windows Issues specific for Windows labels Aug 20, 2022
@HebaruSan HebaruSan changed the title Hide tray icon at exit Hide tray icon at exit via ctrl-C Aug 20, 2022
@HebaruSan HebaruSan force-pushed the fix/tray-icon-close branch 3 times, most recently from 6ee4107 to 0454409 Compare August 21, 2022 21:53
Copy link
Member

@techman83 techman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is something I've had to do in other applications

@HebaruSan HebaruSan merged commit bedf910 into KSP-CKAN:master Aug 23, 2022
@HebaruSan HebaruSan deleted the fix/tray-icon-close branch August 23, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Easy This is easy to fix Enhancement New features or functionality GUI Issues affecting the interactive GUI Windows Issues specific for Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants