Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store remote version file URL in metadata resources #3259

Merged

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Jan 6, 2021

Motivation

When investigating issues with mods' compatiiblity, the one piece of info that isn't readily available on http://status.ksp-ckan.space/ is the remote version file URL, which is important because it contains the latest compatibility data that is used for inflation. To get this, we have to download the ZIP and read the internal version file.

Changes

Now resources.remote-avc is populated with the remote version file URL when available and displayed in GUI. I believe this will also flow through to the status page with no further changes, see KSP-CKAN/NetKAN-status#9.

The spec and schema are updated to support this new property, but I don't think we need to bump the minor version of the next CKAN release for this.

    "resources": {
        "homepage": "https://forum.kerbalspaceprogram.com/index.php?/topic/155998-*",
        "repository": "https://github.com/HebaruSan/Astrogator",
        "bugtracker": "https://github.com/HebaruSan/Astrogator/issues",
        "remote-avc": "https://raw.githubusercontent.com/HebaruSan/Astrogator/master/Astrogator.version"
    },

@HebaruSan HebaruSan added Enhancement New features or functionality GUI Issues affecting the interactive GUI Core (ckan.dll) Issues affecting the core part of CKAN Pull request Spec Issues affecting the spec Netkan Issues affecting the netkan data Schema Issues affecting the schema labels Jan 6, 2021
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried my best finding a suitable translation for "Remote version file", not that easy :D
Probably not very useful for the average user, but all the more for us, and maybe some modders.

@HebaruSan HebaruSan merged commit 388b1a8 into KSP-CKAN:master Jan 8, 2021
@HebaruSan HebaruSan deleted the feature/remote-version-file-resource branch January 8, 2021 23:00
@DasSkelett DasSkelett added the i18n Issues regarding the internationalization of CKAN and PRs that need translating label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating Netkan Issues affecting the netkan data Schema Issues affecting the schema Spec Issues affecting the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants