Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netkan warning for archived repos, set bugtracker for GitHub #3061

Merged
merged 5 commits into from
May 25, 2020

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented May 24, 2020

Motivation

A GitHub repo can be "archived", meaning that it's effectively read-only and very unlikely to ever be updated. Currently some of the netkans that we crawl every 2 hours are probably archived, so it's not necessary to keep checking them, but we don't know about it.

There's a resources.bugtracker property in the spec, but it's only populated manually. Many mods are hosted on GitHub repos where issues can be submitted, but we don't check that.

Changes

  • Now if a GitHub repo is archived, Netkan will print a warning suggesting that we freeze that netkan, which will be visible on the status page
  • Now if a GitHub repo has issues enabled (not all of them do), resources.bugtracker will automatically be set to that repo's issues list
  • The duration of caching of strings from Request fewer GitHub releases and cache string URLs in Netkan #2950 is extended from 2 to 15 minutes, since that's about what a typical bot pass takes
  • The warning about ModuleManager syntax now prints the affected filenames to ease investigation
  • The ModuleManager syntax regexp is updated to detect post-clauses without leading special operator characters:
    PART:NEEDS[NEBULA]
    {
    
    SCALETYPE:NEEDS[TweakScale]
    {
    
    MATERIAL:NEEDS[RealChute]
    {
    
    PART:NEEDS[Launchpad]
    {
    

@HebaruSan HebaruSan added Enhancement New features or functionality Easy This is easy to fix Pull request Netkan Issues affecting the netkan data labels May 24, 2020
@HebaruSan HebaruSan requested a review from DasSkelett May 24, 2020 18:21
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know of an archived repository to check the archive detection feature, but I guess we'll find out if it works :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix Enhancement New features or functionality Netkan Issues affecting the netkan data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants