Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purge stale cache entries for SpaceDock #2859

Merged
merged 1 commit into from
May 5, 2020
Merged

Purge stale cache entries for SpaceDock #2859

merged 1 commit into from
May 5, 2020

Conversation

HebaruSan
Copy link
Member

This is #2337, but for SpaceDock.

Needs KSP-SpaceDock/SpaceDock#195 to be merged to SpaceDock's production. Currently it's still being tested on the alpha server.

@HebaruSan HebaruSan added Easy This is easy to fix Enhancement New features or functionality In progress We're still working on this Netkan Issues affecting the netkan data Pull request labels Aug 28, 2019
@HebaruSan
Copy link
Member Author

The SD change has advanced from the alpha to the beta server.

https://beta.spacedock.info/api/mod/2

{"name": "netkan", "id": 2, "game": "Kerbal Space Program", "game_id": 1, "short_description": "The EXE that CKAN uses to inflate metadata", "downloads": 0, "followers": 0, "author": "HebaruSan", "default_version_id": 2, "shared_authors": [{"username": "DasSkelett", "description": " ", "forumUsername": "DasSkelett", "ircNick": "DasSkelett", "twitterUsername": "DasSkelett ", "redditUsername": ""}], "background": null, "bg_offset_y": null, "license": "MIT", "website": "", "donations": "", "source_code": "", "url": "/mod/2/netkan", "versions": [{"friendly_version": "v1.26.78fec44d2ad73", "game_version": "1.8.1", "id": 2, "created": "2020-01-24T00:09:33.066554", "download_path": "/mod/2/netkan/download/v1.26.78fec44d2ad73", "changelog": null}], "description": "Just a junk file for testing.", "description_html": "<p>Just a junk file for testing.</p>"}

@techman83
Copy link
Member

Is that a field that could be used for #2916 ?

@HebaruSan
Copy link
Member Author

Yes, I suppose so.

@HebaruSan
Copy link
Member Author

It's in production!

https://spacedock.info/api/mod/10

... "created": "2020-02-13T14:43:30.329419", ...

@HebaruSan HebaruSan force-pushed the feature/spacedock-cache-autopurge branch from 081d4d3 to f139400 Compare May 4, 2020 18:02
@HebaruSan HebaruSan removed the In progress We're still working on this label May 4, 2020
@HebaruSan HebaruSan requested a review from DasSkelett May 4, 2020 18:03
DasSkelett
DasSkelett approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit hard to test, but I can see the "x_netkan_asset_updated": "..." being added to the metadata, so I hope the rest works as well, :D

@HebaruSan HebaruSan merged commit 51d8f85 into KSP-CKAN:master May 5, 2020
@HebaruSan HebaruSan deleted the feature/spacedock-cache-autopurge branch May 5, 2020 14:21
@HebaruSan HebaruSan mentioned this pull request May 5, 2020
Closed
@DasSkelett
Copy link
Member

Looks good, already had an effect:
KSP-CKAN/CKAN-meta@b52717c

@HebaruSan HebaruSan mentioned this pull request May 21, 2020
Merged
@DasSkelett DasSkelett mentioned this pull request Jun 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DasSkelett DasSkelett DasSkelett approved these changes

Assignees
No one assigned
Labels
Easy This is easy to fix Enhancement New features or functionality Netkan Issues affecting the netkan data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HebaruSan @techman83 @DasSkelett