Show innermost download exceptions #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Easy
politas
added a commit
that referenced
this pull request
Oct 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#2527 shows a bunch of errors along these lines:
This says "An exception" instead of specifying what the problem is because it's one of .NET's annoying wrapper exceptions. The useful info is hidden in
exception.InnerException, orexception.InnerException.InnerException, or evenexception.InnerException.InnerException.InnerException.Changes
Now we use
GetBaseExceptionas we did #2480 to strip off all the wrapper exceptions and display the actual problem. This is not a fix for #2527, but it makes such problems more debuggable. We can share a test build with that issue's author if the issue happens consistently for them.