Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"any" and "x.y.max" in the KSP Max column (GUI) #2437

Merged
merged 1 commit into from
May 15, 2018

Conversation

yalov
Copy link
Contributor

@yalov yalov commented Apr 29, 2018

#2432
add dictionary, should be ok.

// don't like that, but it is the right way
0.90.0 → 0.90.0
0.90   → 0.90.9     

// there is v1.2.9, so 1.2.max is 1.2.99
1.2.9   → 1.2.9  
1.2.45  → 1.2.45
1.2.99  → 1.2.99
1.2.999 → 1.2.99

1.4     → 1.4.9   // there isn't 1.4.9, when it does - 1.4 → 1.4.99
1.4.3   → 1.4.3
1.4.90  → 1.4.9 
1.4.99  → 1.4.9

1.9 or 1.9.x   → any   // there isn't 1.9.0, when it does - 1.99.x → any
2.0.0 → any               // discussable
9.99.99 → any

@Olympic1
Copy link
Member

Olympic1 commented Apr 29, 2018

Shouldn't we limit 1.2.x to 1.2.8 as 1.2.9 was the pre-release for 1.3

@yalov
Copy link
Contributor Author

yalov commented Apr 30, 2018

your question is about how it works at scan, you are trying to say what 1.2 or 1.2.99 really not compatible with 1.2.9, because 1.2.9 is 1.3.0.rc.

I am not trying to solve that, it is just about column gui. People who cares already set 1.2.8, but if someone set 1.2.999 it is works for 1.2.9 and column value should respect that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants