Merge #2175 Clean up registry lock file after parse failure

KSP-CKAN · Nov 6, 2017 · 51893b1 · 51893b1
2 parents 4d3d978 + 8c3332b
commit 51893b1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,7 @@ All notable changes to this project will be documented in this file.
 - [Build] Fix build errors for UpdateCol (#2153 by: politas; reviewed: Olympic1)
 - [Core] Simplify IUser (#2163 by: HebaruSan; reviewed: politas)
 - [Auto-updater] Move AskForAutoUpdates dialog to center of screen (#2165 by: politas; reviewed: Olympic1)
+- [Core] Clean up registry lock file after parse failure (#2175 by: HebaruSan; reviewed: politas)
 
 ## v1.22.6 (Guiana)
 

diff --git a/Core/Registry/RegistryManager.cs b/Core/Registry/RegistryManager.cs
@@ -47,7 +47,16 @@ private RegistryManager(string path, KSP ksp)
                 throw new RegistryInUseKraken(lockfilePath);
             }
 
-            LoadOrCreate();
+            try
+            {
+                LoadOrCreate();
+            }
+            catch
+            {
+                // Clean up the lock file
+                Dispose(false);
+                throw;
+            }
 
             // We don't cause an inconsistency error to stop the registry from being loaded,
             // because then the user can't do anything to correct it. However we're