readout of the emb electron energy scale with correctionlibs #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrypuuter
approved these changes
Feb 7, 2024
| /// \param[out] corrected_pt name of the corrected tau pt to be calculated | ||
| /// \param[in] pt name of the raw tau pt | ||
| /// \param[in] eta name of raw tau eta | ||
| /// \param[in] sf_barrel scale factor to be applied to electrons in the barrel |
There was a problem hiding this comment.
thats the name of the sf right? so something like sf_barrel_name would maybe be better
There was a problem hiding this comment.
i think I would leave it, as it is the same in the tau and mu pt correction functions. It is "nom", "up" or "down"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correctionlibs for Run-2UL emb electron energy scale
made a new function, to read out the sfs for the emb electron energy scales
remark: 2017 is not ready yet and only filled with dummy values