feat: relocation of ctype config #78

aybarsayan · 2024-01-31T08:59:29Z

fixes KILTProtocol/ticket#2911

The 'Ctype Hash' and 'Attester DID' have been moved to the .env file. Additionally, if a user does not specify one, it will automatically use the email ctype. A new ticket has been opened to list valid Ctype hashes in the readme.md file. See Ticket #3103.

How to test:

Please provide a brief step-by-step instruction.
If necessary provide information about dependencies (specific configuration, branches, database dumps, etc.)

Step 1
Step 2
etc.

Checklist:

I have verified that the code works
I have verified that the code is easy to understand
- If not, I have left a well-balanced amount of inline comments
I have left the code in a better state
I have documented the changes (where applicable)
- Either PR or Ticket to update the Docs
- Link the PR/Ticket here

rompemoldes

Mostly nice. Makes it easier.

Not so happy with the comments (code explainers) though. They are important because this is an educational project.

Support for both chains would also be nice, or at least say that by default it only works with SocialKYC on Peregrine.

.oldenv

backend/src/config.ts

backend/src/credentials/listOfRequests.ts

rompemoldes · 2024-01-31T14:03:25Z

backend/src/credentials/listOfRequests.ts

+// Here you can set which type of credential (cType) your dApp will request users to login.
+// You can change it by importing a different one.
+// The default is the Email CType by SocialKYC and SocialKYC as the Issuer
 // Establish which cTypes our dApp accepts and which attesters we trust:



I think that all this comments could go inside the variable explainer (docs) from requestedCTypeForLogin. Maybe a bit more structured and explaining how to change the imports.

backend/src/access/login.ts

rompemoldes · 2024-01-31T14:37:13Z

backend/src/credentials/listOfRequests.ts

+const trustedAttestersValues = TRUSTED_ATTESTERS.split(',')
+const requiredPropertiesValues = REQUIRED_PROPERTIES.split(',')
+
+const requiredProperties = requiredPropertiesValues.map(
+  (requiredProperties) => requiredProperties
+)
+
+const trustedAttesters = trustedAttestersValues.map(
+  (trustedAttesters) => trustedAttesters as Kilt.DidUri
+)


Suggested change

const trustedAttestersValues = TRUSTED_ATTESTERS.split(',')

const requiredPropertiesValues = REQUIRED_PROPERTIES.split(',')

const requiredProperties = requiredPropertiesValues.map(

(requiredProperties) => requiredProperties

)

const trustedAttesters = trustedAttestersValues.map(

(trustedAttesters) => trustedAttesters as Kilt.DidUri

)

const trustedAttesters = TRUSTED_ATTESTERS.split(',') as Kilt.DidUri[]

const requiredProperties = REQUIRED_PROPERTIES.split(',')

backend/src/credentials/listOfRequests.ts

ntn-x2

Nice added flexibility! There are few points that are not clear to me, that I'd like to get clarified.

backend/src/config.ts

.env.example

backend/src/config.ts

ntn-x2 · 2024-02-01T05:49:31Z

backend/src/credentials/listOfRequests.ts

+const trustedAttestersValues = TRUSTED_ATTESTERS.split(',')
+const requiredPropertiesValues = REQUIRED_PROPERTIES.split(',')
+
+const requiredProperties = requiredPropertiesValues.map(


What is this snippet of code doing exactly?

This comment still not addressed.

it was a experimental change to accept more than one TRUSTED_ATTESTERS which separated by a comma

Dudleyneedham

Minor comment to remove the default.

README.md

backend/src/credentials/ctypeRequest.ts

ntn-x2

Please resolve any conflicts with the base branch, and gather an approval from @kilted-andres.

rompemoldes · 2024-02-15T09:51:54Z

backend/src/credentials/ctypeRequest.ts

+const trustedAttesters = TRUSTED_ATTESTERS.split(',').map((s)=> {
+  const trimmed = s.trim()
+  Kilt.Did.validateUri(trimmed)
+  return trimmed as Kilt.DidUri
+})
+const requiredProperties = REQUIRED_PROPERTIES.split(',').map((s)=> s.trim())


Please use variable names that describe the variable.

Maybe didUri and property?

rompemoldes · 2024-02-15T09:55:07Z

backend/src/credentials/ctypeRequest.ts

+// Here you can set which type of credential (cType) your dApp will request users to login.
+// You can change it by importing a different one.
+// Establish which cTypes our dApp accepts and which attesters we trust:


I would replace this by adding an explainer (docs) to the variable cTypeToRequest.

Maybe something like this:

/** Establish which type of credential (cType) our dApp will request users to login, * which properties are necessary and which attesters we trust. * * This is defined by the constants imported from the config. * Modify the `env`-file to adapt it to your liking. */ export const cTypeToRequest: Kilt.IRequestCredentialContent = {

Please add this and rename the variable to be in plural.

Done at: 4868513

rompemoldes · 2024-02-15T09:57:51Z

backend/src/credentials/ctypeRequest.ts

This file does not include the cTypeRequest. The request is prepare on buildCredentialRequest.

Please, rename this file to cTypeToRequest.

Can you please do this? 🙏

Now in plural cTypesToRequest

Done at: 4868513

.env.example

backend/src/access/login.ts

rompemoldes · 2024-02-15T10:33:46Z

backend/src/access/login.ts

+    // Check if any properties have been provided. If not, log in as 'Anonymous User'. 
+    // If any property exists, send the object's first value as 'authenticationToken' 
+    // to ensure login with any 'ctype'.


Ideally, authenticationToken does not have the plain user info, but rather something only the server can identify. How authentification tokens are made changes from website to website. Because we did not want to prescribe people how to do it, we took the simplest approach (some plain user info) and encourage people customize it afterwards.

Suggested change

// Check if any properties have been provided. If not, log in as 'Anonymous User'.

// If any property exists, send the object's first value as 'authenticationToken'

// to ensure login with any 'ctype'.

// Check if any properties have been provided. If not, send 'Anonymous User' to display on the frontend.

// If any property exists, send object's first attribute value,

// ensuring compatibility with any 'cType'.

Done at: 4fe1b4e

backend/src/config.ts

rompemoldes · 2024-02-15T12:06:26Z

README.md

@@ -129,6 +129,23 @@ The following variables are required:
 - `DAPP_DID_URI` = _This is the URI of the Kilt DID that identifies your dApp_
 - `DAPP_NAME` = _This should be a custom name for your dApp_
 - `JWT_SIGNER_SECRET` = _This is secret key (string) that signs the Json-Web-Tokens before saving them in the Cookies_
+- `CTYPE_HASH` = _This is type of credential (CType) your dApp will request from users for login_
+- `TRUSTED_ATTESTERS` = _This is the DID that identifies the attestors whose attestations are accepted_


Suggested change

- `TRUSTED_ATTESTERS` = _This is the DID that identifies the attestors whose attestations are accepted_

- `TRUSTED_ATTESTERS` = _This is a list of attesters DIDs (c.s.v.`,`). Only credentials issued by them will be considered valid_

Done at: 4fe1b4e

rompemoldes · 2024-02-15T12:19:34Z

README.md

@@ -129,6 +129,23 @@ The following variables are required:
 - `DAPP_DID_URI` = _This is the URI of the Kilt DID that identifies your dApp_
 - `DAPP_NAME` = _This should be a custom name for your dApp_
 - `JWT_SIGNER_SECRET` = _This is secret key (string) that signs the Json-Web-Tokens before saving them in the Cookies_
+- `CTYPE_HASH` = _This is type of credential (CType) your dApp will request from users for login_
+- `TRUSTED_ATTESTERS` = _This is the DID that identifies the attestors whose attestations are accepted_
+- `REQUIRED_PROPERTIES` = _These are the required properties that identify the CType_


Suggested change

- `REQUIRED_PROPERTIES` = _These are the required properties that identify the CType_

- `REQUIRED_PROPERTIES` = _This is a subset of CType properties (c.s.v.`,`) required to be exposed on credential presentation_

This properties do not define the CType. They are just the properties out of the CType that we are asking for.

Done at: 4fe1b4e

rompemoldes

One last but big thing is:
Please, update genesisEnvironmentVariables.ts to ask developers to set up the 3 new environment variables. You can then suggest our "defaults" on the prompts.

README.md

rompemoldes · 2024-02-15T13:45:41Z

README.md

+
+To proceed, you may select the desired credential through the CType Environment Variables listed below, allowing you to tailor the authentication process to your needs.
+
+| Socail KYC | CTYPE_HASH                                                         | TRUSTED_ATTESTERS(spiritnet)                              | TRUSTED_ATTESTERS(peregrine)                              | REQUIRED_PROPERTIES |


The whole table just has some useful information about some recommended cTypes. I would give it an according description and also a title (via ###on markdown). Maybe "Info about example/recommended cTypes" or something like that.

Please, also signalise somehow that we only recommend SocialKYC and the types of credentials it issues.
This is also a good place to explain why the cType-hash is the same for both chains.

The first row is not great. The first column should be "Title", not "SocialKYC".

Both TRUSTED_ATTESTERS(spiritnet) and TRUSTED_ATTESTERS(peregrine) should rather be SocialKYC on Spiritnet or on SocialKYC on Peregrine.

Maybe you can first list the two SocialKYC DIDs and then add references to them on the table. Then you can leave the title Trusted Attesters. That would be more fitting, if later we decide to add an external attester to this list.

You will have to make them subtitles to be able to reference them, like this:

####SocialKYC on the Production: did:kilt:... And then inside the table (prod. SYKC)[#SocialKYC on the Production]

And on the properties column is maybe better to include all properties and let them decide. This would make the "required" part false. But the columns name really don't need to be the name of the CONSTANTS.

Done at: 4fe1b4e

README.md

aybarsayan

Thanks for the review

.env.example

README.md

aybarsayan · 2024-02-29T08:31:56Z

README.md

@@ -129,6 +129,23 @@ The following variables are required:
 - `DAPP_DID_URI` = _This is the URI of the Kilt DID that identifies your dApp_
 - `DAPP_NAME` = _This should be a custom name for your dApp_
 - `JWT_SIGNER_SECRET` = _This is secret key (string) that signs the Json-Web-Tokens before saving them in the Cookies_
+- `CTYPE_HASH` = _This is type of credential (CType) your dApp will request from users for login_
+- `TRUSTED_ATTESTERS` = _This is the DID that identifies the attestors whose attestations are accepted_


Done at: 4fe1b4e

aybarsayan · 2024-02-29T08:31:59Z

README.md

@@ -129,6 +129,23 @@ The following variables are required:
 - `DAPP_DID_URI` = _This is the URI of the Kilt DID that identifies your dApp_
 - `DAPP_NAME` = _This should be a custom name for your dApp_
 - `JWT_SIGNER_SECRET` = _This is secret key (string) that signs the Json-Web-Tokens before saving them in the Cookies_
+- `CTYPE_HASH` = _This is type of credential (CType) your dApp will request from users for login_
+- `TRUSTED_ATTESTERS` = _This is the DID that identifies the attestors whose attestations are accepted_
+- `REQUIRED_PROPERTIES` = _These are the required properties that identify the CType_


Done at: 4fe1b4e

aybarsayan · 2024-02-29T08:32:01Z

README.md

+
+To proceed, you may select the desired credential through the CType Environment Variables listed below, allowing you to tailor the authentication process to your needs.
+
+| Socail KYC | CTYPE_HASH                                                         | TRUSTED_ATTESTERS(spiritnet)                              | TRUSTED_ATTESTERS(peregrine)                              | REQUIRED_PROPERTIES |


Done at: 4fe1b4e

README.md

aybarsayan · 2024-02-29T08:32:11Z

backend/src/access/login.ts

+    // Check if any properties have been provided. If not, log in as 'Anonymous User'. 
+    // If any property exists, send the object's first value as 'authenticationToken' 
+    // to ensure login with any 'ctype'.


Done at: 4fe1b4e

aybarsayan · 2024-02-29T10:13:36Z

One last but big thing is: Please, update genesisEnvironmentVariables.ts to ask developers to set up the 3 new environment variables. You can then suggest our "defaults" on the prompts.

This is resolved at: 8c89cc8

rompemoldes

Very Good!

I haven't tried the multiple cTypes yet, thats why I haven't approve yet.

rompemoldes · 2024-03-13T17:09:42Z

README.md

+- `CTYPE_HASH` = _This is the type of credential (CType) your dApp will request from users for login. If you want to specify more than one CType, you can do so by adding a '/' sign between them_
+- `TRUSTED_ATTESTERS` = _This is a list of attester DIDs (CSV, separated by ','). Only credentials issued by these attesters will be considered valid. If you are using more than one CType, you can specify the trusted attesters by adding a '/' sign between them_
+- `REQUIRED_PROPERTIES` = _This is a subset of CType properties (CSV, separated by ',') required to be exposed on credential presentation. If you are using more than one CType, you can specify the required properties by adding a '/' sign between them._


Thank yo 😊 really appreciated

rompemoldes · 2024-03-13T17:11:55Z

backend/src/credentials/ctypeRequest.ts

+// Here you can set which type of credential (cType) your dApp will request users to login.
+// You can change it by importing a different one.
+// Establish which cTypes our dApp accepts and which attesters we trust:


Please add this and rename the variable to be in plural.

rompemoldes · 2024-03-13T17:12:18Z

backend/src/credentials/ctypeRequest.ts

Now in plural cTypesToRequest

rompemoldes · 2024-03-13T18:00:53Z

scripts/genesisEnvironmentVariables.ts

+function imploreCtypeHash() {
+  console.log(
+    'Please provide a name for your CTYPE_HASH inside the .env file using this constant name: \n',
+    `CTYPE_HASH={your CType Hash}\n`,
+    `If you wish to use the default Email Credential settings, please add the following line to your .env file:\n`,
+    `CTYPE_HASH=0x3291bb126e33b4862d421bfaa1d2f272e6cdfc4f96658988fbcffea8914bd9ac\n`
+  )
+}


Suggested change

function imploreCtypeHash() {

console.log(

'Please provide a name for your CTYPE_HASH inside the .env file using this constant name: \n',

`CTYPE_HASH={your CType Hash}\n`,

`If you wish to use the default Email Credential settings, please add the following line to your .env file:\n`,

`CTYPE_HASH=0x3291bb126e33b4862d421bfaa1d2f272e6cdfc4f96658988fbcffea8914bd9ac\n`

)

}

function imploreCtypeHash() {

console.log(

'Please provide the CType Hash(es) inside the .env file using this constant name:.\n',

'Your dApp will only accept credentials of this given Claim Type(s).',

`CTYPE_HASH={CType IDs your dApp consider valid}\n`,

`If you wish to use the default Email Credential settings, please add the following line to your .env file:\n`,

`CTYPE_HASH=0x3291bb126e33b4862d421bfaa1d2f272e6cdfc4f96658988fbcffea8914bd9ac\n`

)

}

Done at: 4868513

rompemoldes · 2024-03-13T18:01:17Z

scripts/genesisEnvironmentVariables.ts

+function imploreTrustedAttesters() {
+  console.log(
+    'Please provide a list for your Trusted Attesters inside the .env file using this constant name: \n',
+    `TRUSTED_ATTESTERS={lists of trusted attesters}\n`,
+    `If you wish to use the default Email Credential settings, please add the following line to your .env file:\n`,
+    `TRUSTED_ATTESTERS=did:kilt:4pehddkhEanexVTTzWAtrrfo2R7xPnePpuiJLC7shQU894aY\n`
+  )
+}


Suggested change

function imploreTrustedAttesters() {

console.log(

'Please provide a list for your Trusted Attesters inside the .env file using this constant name: \n',

`TRUSTED_ATTESTERS={lists of trusted attesters}\n`,

`If you wish to use the default Email Credential settings, please add the following line to your .env file:\n`,

`TRUSTED_ATTESTERS=did:kilt:4pehddkhEanexVTTzWAtrrfo2R7xPnePpuiJLC7shQU894aY\n`

)

}

function imploreTrustedAttesters() {

console.log(

'Please provide a list for your Trusted Attesters inside the .env file using this constant name: \n',

'Your dApp will only accept credentials issued by one of this attesters.',

`TRUSTED_ATTESTERS={lists of trusted attesters}\n`,

`If you wish to use the default and accept Credentials issued by SocialKYC.io on Peregrine, please add the following line to your .env file:\n`,

`TRUSTED_ATTESTERS=did:kilt:4pehddkhEanexVTTzWAtrrfo2R7xPnePpuiJLC7shQU894aY\n`

)

}

Done at: 4868513

rompemoldes · 2024-03-13T18:01:44Z

scripts/genesisEnvironmentVariables.ts

+function imploreRequestedProperties() {
+  console.log(
+    'Please provide a list for your Requested Properties inside the .env file using this constant name: \n',
+    `REQUIRED_PROPERTIES={lists of Requested Properties}\n`,
+    `If you wish to use the default Email Credential settings, please add the following line to your .env file:\n`,
+    `REQUIRED_PROPERTIES=Email\n`
+  )
+}


Suggested change

function imploreRequestedProperties() {

console.log(

'Please provide a list for your Requested Properties inside the .env file using this constant name: \n',

`REQUIRED_PROPERTIES={lists of Requested Properties}\n`,

`If you wish to use the default Email Credential settings, please add the following line to your .env file:\n`,

`REQUIRED_PROPERTIES=Email\n`

)

}

function imploreRequestedProperties() {

console.log(

'Please provide a list of Required Properties inside the .env file using this constant name: \n',

`REQUIRED_PROPERTIES={lists of Properties users should be Required to disclose}\n`,

`If you wish to use the default Email Credential settings, please add the following line to your .env file:\n`,

`REQUIRED_PROPERTIES=Email\n`

)

}

Done at: 4868513

rompemoldes · 2024-03-13T18:04:19Z

README.md

+#### SocialKYC on Spiritnet: did:kilt:4pnfkRn5UurBJTW92d9TaVLR2CqJdY4z5HPjrEbpGyBykare
+
+#### SocialKYC on Peregrine: did:kilt:4pehddkhEanexVTTzWAtrrfo2R7xPnePpuiJLC7shQU894aY


The title and the content need to be on different lines. Right now the links on the table do not work.

You can also add the links from the websites here, e.g. https://test.socialkyc.io and https://socialkyc.io

Done at: 4868513

rompemoldes

Nice work, man.

I now tested the support for multiple cTypes. Awesome!

Please, follow what I suggested on the last comments (and the ones long forgotten) before doing the merge.

You have waited enough. Approved. 🚀

rompemoldes · 2024-03-13T18:35:48Z

README.md

@@ -129,6 +122,33 @@ The following variables are required:
 - `DAPP_DID_URI` = _This is the URI of the Kilt DID that identifies your dApp_
 - `DAPP_NAME` = _This should be a custom name for your dApp_
 - `JWT_SIGNER_SECRET` = _This is secret key (string) that signs the Json-Web-Tokens before saving them in the Cookies_
+- `CTYPE_HASH` = _This is the type of credential (CType) your dApp will request from users for login. If you want to specify more than one CType, you can do so by adding a '/' sign between them_
+- `TRUSTED_ATTESTERS` = _This is a list of attester DIDs (CSV, separated by ','). Only credentials issued by these attesters will be considered valid. If you are using more than one CType, you can specify the trusted attesters by adding a '/' sign between them_


Suggested change

- `TRUSTED_ATTESTERS` = _This is a list of attester DIDs (CSV, separated by ','). Only credentials issued by these attesters will be considered valid. If you are using more than one CType, you can specify the trusted attesters by adding a '/' sign between them_

- `TRUSTED_ATTESTERS` = _This is a list of attester DIDs (CSV, separated by ','). Only credentials issued by these attesters will be considered valid. If you are using more than one CType, indicate the groups of trusted attesters by respectively separating them with a '/' sign._

Do it similarly for the REQUIRED_PROPERTIES

Done at: 4868513

aybarsayan

Thank you so much for your reviews 😊

aybarsayan · 2024-03-13T19:14:16Z

README.md

@@ -129,6 +122,33 @@ The following variables are required:
 - `DAPP_DID_URI` = _This is the URI of the Kilt DID that identifies your dApp_
 - `DAPP_NAME` = _This should be a custom name for your dApp_
 - `JWT_SIGNER_SECRET` = _This is secret key (string) that signs the Json-Web-Tokens before saving them in the Cookies_
+- `CTYPE_HASH` = _This is the type of credential (CType) your dApp will request from users for login. If you want to specify more than one CType, you can do so by adding a '/' sign between them_
+- `TRUSTED_ATTESTERS` = _This is a list of attester DIDs (CSV, separated by ','). Only credentials issued by these attesters will be considered valid. If you are using more than one CType, you can specify the trusted attesters by adding a '/' sign between them_


Done at: 4868513

aybarsayan · 2024-03-13T19:14:23Z

README.md

+#### SocialKYC on Spiritnet: did:kilt:4pnfkRn5UurBJTW92d9TaVLR2CqJdY4z5HPjrEbpGyBykare
+
+#### SocialKYC on Peregrine: did:kilt:4pehddkhEanexVTTzWAtrrfo2R7xPnePpuiJLC7shQU894aY


Done at: 4868513

aybarsayan · 2024-03-13T19:17:43Z

backend/src/credentials/ctypeRequest.ts

Done at: 4868513

aybarsayan · 2024-03-13T19:17:48Z

backend/src/credentials/ctypeRequest.ts

+// Here you can set which type of credential (cType) your dApp will request users to login.
+// You can change it by importing a different one.
+// Establish which cTypes our dApp accepts and which attesters we trust:


Done at: 4868513

aybarsayan · 2024-03-13T19:17:54Z

scripts/genesisEnvironmentVariables.ts

+function imploreCtypeHash() {
+  console.log(
+    'Please provide a name for your CTYPE_HASH inside the .env file using this constant name: \n',
+    `CTYPE_HASH={your CType Hash}\n`,
+    `If you wish to use the default Email Credential settings, please add the following line to your .env file:\n`,
+    `CTYPE_HASH=0x3291bb126e33b4862d421bfaa1d2f272e6cdfc4f96658988fbcffea8914bd9ac\n`
+  )
+}


Done at: 4868513

aybarsayan · 2024-03-13T19:18:02Z

scripts/genesisEnvironmentVariables.ts

+function imploreTrustedAttesters() {
+  console.log(
+    'Please provide a list for your Trusted Attesters inside the .env file using this constant name: \n',
+    `TRUSTED_ATTESTERS={lists of trusted attesters}\n`,
+    `If you wish to use the default Email Credential settings, please add the following line to your .env file:\n`,
+    `TRUSTED_ATTESTERS=did:kilt:4pehddkhEanexVTTzWAtrrfo2R7xPnePpuiJLC7shQU894aY\n`
+  )
+}


Done at: 4868513

aybarsayan · 2024-03-13T19:18:04Z

scripts/genesisEnvironmentVariables.ts

+function imploreRequestedProperties() {
+  console.log(
+    'Please provide a list for your Requested Properties inside the .env file using this constant name: \n',
+    `REQUIRED_PROPERTIES={lists of Requested Properties}\n`,
+    `If you wish to use the default Email Credential settings, please add the following line to your .env file:\n`,
+    `REQUIRED_PROPERTIES=Email\n`
+  )
+}


Done at: 4868513

config ctype to .env

973a34f

aybarsayan requested review from Dudleyneedham and rompemoldes January 31, 2024 08:59

weichweich requested a review from ntn-x2 January 31, 2024 10:42

rompemoldes requested changes Jan 31, 2024

View reviewed changes

rompemoldes reviewed Jan 31, 2024

View reviewed changes

ntn-x2 reviewed Feb 1, 2024

View reviewed changes

feat: making the requested changes

1302a8f

aybarsayan requested review from rompemoldes and ntn-x2 February 5, 2024 08:50

feat: ctype table addation

fcb7054

Dudleyneedham reviewed Feb 13, 2024

View reviewed changes

remove default values

33828af

ntn-x2 reviewed Feb 14, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

backend/src/credentials/ctypeRequest.ts Outdated Show resolved Hide resolved

feat: mapfix

99ad5a6

ntn-x2 approved these changes Feb 14, 2024

View reviewed changes

rompemoldes requested changes Feb 15, 2024

View reviewed changes

rompemoldes reviewed Feb 15, 2024

View reviewed changes

rompemoldes requested changes Feb 15, 2024

View reviewed changes

rompemoldes reviewed Feb 15, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

rompemoldes reviewed Feb 15, 2024

View reviewed changes

README.md Show resolved Hide resolved

fix: pr changes

4fe1b4e

aybarsayan commented Feb 29, 2024

View reviewed changes

fix: genesisEnv

8c89cc8

aybarsayan requested a review from rompemoldes March 7, 2024 11:08

aybarsayan added 2 commits March 13, 2024 12:59

feat: ability to use more than one ctype

177b978

fix: lint

6e32123

rompemoldes reviewed Mar 13, 2024

View reviewed changes

rompemoldes approved these changes Mar 13, 2024

View reviewed changes

fix: some Review Changes

4868513

aybarsayan commented Mar 13, 2024

View reviewed changes

fix: log remove

e1e82a4

aybarsayan closed this Mar 13, 2024

aybarsayan force-pushed the main branch from e1e82a4 to 2782fe6 Compare March 13, 2024 20:35

aybarsayan added 3 commits March 13, 2024 23:42

fix: export

692758b

fix: Ctype type

d716392

Merge branch 'main' of https://github.com/aybarsayan/web3-login-demo

36833d7

aybarsayan reopened this Mar 13, 2024

fix: lint fixes

4558746

aybarsayan merged commit 0882d58 into KILTprotocol:main Mar 13, 2024
1 check passed

	- `TRUSTED_ATTESTERS` = _This is the DID that identifies the attestors whose attestations are accepted_
	- `TRUSTED_ATTESTERS` = _This is a list of attesters DIDs (c.s.v.`,`). Only credentials issued by them will be considered valid_

	- `REQUIRED_PROPERTIES` = _These are the required properties that identify the CType_
	- `REQUIRED_PROPERTIES` = _This is a subset of CType properties (c.s.v.`,`) required to be exposed on credential presentation_


		To proceed, you may select the desired credential through the CType Environment Variables listed below, allowing you to tailor the authentication process to your needs.

		\| Socail KYC \| CTYPE_HASH \| TRUSTED_ATTESTERS(spiritnet) \| TRUSTED_ATTESTERS(peregrine) \| REQUIRED_PROPERTIES \|

		#### SocialKYC on Spiritnet: did:kilt:4pnfkRn5UurBJTW92d9TaVLR2CqJdY4z5HPjrEbpGyBykare

		#### SocialKYC on Peregrine: did:kilt:4pehddkhEanexVTTzWAtrrfo2R7xPnePpuiJLC7shQU894aY

feat: relocation of ctype config #78

feat: relocation of ctype config #78

Conversation

aybarsayan commented Jan 31, 2024 • edited Loading

fixes KILTProtocol/ticket#2911

How to test:

Checklist:

rompemoldes left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ntn-x2 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dudleyneedham left a comment

Choose a reason for hiding this comment

ntn-x2 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rompemoldes Feb 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rompemoldes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aybarsayan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aybarsayan commented Feb 29, 2024

rompemoldes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rompemoldes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aybarsayan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aybarsayan commented Jan 31, 2024 •

edited

Loading

rompemoldes left a comment •

edited

Loading

rompemoldes Feb 15, 2024 •

edited

Loading