chore(deps): polkadot-js as peer dependency #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rflechtner
changed the title
abdulmth
approved these changes
Aug 7, 2024
|
Given that there are some fixes to problematic imports in this PR, I'd cherry-pick this over into the release branch as well and re-release together with a fix for https://github.com/KILTprotocol/ticket/issues/3565 as |
rflechtner
added a commit
that referenced
this pull request
Aug 7, 2024
* chore: make pjs peer dependency in sub-packages * fix: messed-up imports * chore: make some imports more direct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#3058
Set polkadot dependencies as peer dependencies on sub-packages, which should help avoid versioning chaos.
For convenience the sdk-js package still marks all polkadot-js packages as direct dependents.
Checklist: