-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release 0.34.1 #821
Conversation
* Draft PR commit * feat: DID merkle proofs (#744) * Add type definitions for the new dipSender runtime API * Update types with new spec 11000 * Update type definitions * Change keyIds input type * chore: support parties renaming (#751) Rename producer -> provider and receiver -> consumer * chore: update types for additional linked info (#759) Update types * feat: add `dipProvider` pallet for DID extrinsic signing (#764) Add dipProvider pallet for DID extrinsic signing * chore: set package version to 0.33.2-dip-0 * feat: error management (#802) * Error types * Update DIP provider runtime APIs types * Update packages version * feat: add versioning support (#806) * Add version type * Set package versions * Fix identity commitment version type * Update lock file * Changes based on KILTprotocol/kilt-node@1e338a4 * Set version to DIP version * Changes based on KILTprotocol/kilt-node@e23dbcc * Update type definitions * Revert package versions change * Revert yarn.lock changes * Set version to dip-2 * Revert package.json changes * Add runtime calls to Peregrine runtimes
Add missing runtime call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we're planning to keep this an rc though until this gets released on spiritnet right ? otherwise we can't know if the runtime version number you put in there is going to be correct.
@rflechtner our current release strategy do not capture this case when a feature is deployed on Peregrine and not on Spiritnet. Nevertheless, I don't see any blockers from making this a proper release. The new types and definitions will be in AT LEAST runtime 1.12, and also are not relevant if the runtime call is not present, which is the case for Spiritnet runtimes. Why would you not make this an official release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, feel free to publish this as an rc, which should be enough to start integration on testnets. We can stabilise this when the spiritnet release confirms the version ranges for the types.
0.35 has been released, so this will also have to change to the new version. |
We migrated to a different repo and peer dependencies, this PR is not relevant anymore. |
Checklist
0.34.1-rc.1
-> https://github.com/KILTprotocol/sdk-js/tree/0.34.1-rc.1latest-develop
of peregrine and consumer-template