Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export imported types #762

Merged
merged 4 commits into from
Jun 13, 2023
Merged

feat: export imported types #762

merged 4 commits into from
Jun 13, 2023

Conversation

rflechtner
Copy link
Contributor

@rflechtner rflechtner commented May 31, 2023

fixes KILTProtocol/ticket#2697

Re-exports all the types we import in the types package.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner rflechtner requested a review from arty-name June 12, 2023 11:37
Copy link
Collaborator

@arty-name arty-name left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should other SDK packages import these types from the types package?

packages/types/src/Address.ts Outdated Show resolved Hide resolved
@rflechtner
Copy link
Contributor Author

Should other SDK packages import these types from the types package?

Good point!

@rflechtner rflechtner merged commit fbeed97 into develop Jun 13, 2023
@rflechtner rflechtner deleted the rf-export-imported-types branch June 13, 2023 09:43
rflechtner added a commit that referenced this pull request Jul 26, 2023
* feat: re-export imported types from @kiltprotocol/types
* refactor: use re-exported types throughout sdk
rflechtner added a commit that referenced this pull request Aug 3, 2023
* feat: re-export imported types from @kiltprotocol/types
* refactor: use re-exported types throughout sdk
rflechtner added a commit that referenced this pull request Aug 22, 2023
* refactor!: nest ctype in ICTypeDetails (#766)
* refactor: change ctype parameter name to cType where possible

* feat: re-export imported types from @kiltprotocol/types (#762)
* feat: deprecate CType meta schema draft-01 (#778)

* fix: default to log level warn in non-production environments

* test: skip expensive delegation node tests
* test: esm variant of integration tests (#779)
* test: make tests work with new kilt node cli (#796)
* chore: update metadata to 1.11.0
* chore(deps): update cbor-web to v9
* chore(deps-dev): bump webpack from 5.70.0 to 5.76.0 (#771)
* chore(deps-dev): bump semver-regex from 3.1.3 to 3.1.4 (#775)
* chore(deps-dev): bump typedoc to resolve dependency conflict
* ci: make latest-develop tests optional and latest mandatory

Co-authored-by: Gerawork Aynekulu <ggera@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <raphael@kilt.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants