-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export imported types #762
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arty-name
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should other SDK packages import these types from the types package?
Good point! |
rflechtner
added a commit
that referenced
this pull request
Jul 26, 2023
* feat: re-export imported types from @kiltprotocol/types * refactor: use re-exported types throughout sdk
rflechtner
added a commit
that referenced
this pull request
Aug 3, 2023
* feat: re-export imported types from @kiltprotocol/types * refactor: use re-exported types throughout sdk
rflechtner
added a commit
that referenced
this pull request
Aug 22, 2023
* refactor!: nest ctype in ICTypeDetails (#766) * refactor: change ctype parameter name to cType where possible * feat: re-export imported types from @kiltprotocol/types (#762) * feat: deprecate CType meta schema draft-01 (#778) * fix: default to log level warn in non-production environments * test: skip expensive delegation node tests * test: esm variant of integration tests (#779) * test: make tests work with new kilt node cli (#796) * chore: update metadata to 1.11.0 * chore(deps): update cbor-web to v9 * chore(deps-dev): bump webpack from 5.70.0 to 5.76.0 (#771) * chore(deps-dev): bump semver-regex from 3.1.3 to 3.1.4 (#775) * chore(deps-dev): bump typedoc to resolve dependency conflict * ci: make latest-develop tests optional and latest mandatory Co-authored-by: Gerawork Aynekulu <ggera@users.noreply.github.com> Co-authored-by: Raphael Flechtner <raphael@kilt.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#2697
Re-exports all the types we import in the types package.
Checklist: