-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update polkadot dependencies #426
Conversation
4b78f82
to
5069bb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor leftovers, which I have already verified to be unnecessary. I will remove them myself and push the new version.
@@ -7,6 +7,9 @@ const chainProperties = TYPE_REGISTRY.createType('ChainProperties', { | |||
ss58Format: 38, | |||
}) | |||
TYPE_REGISTRY.setChainProperties(chainProperties) | |||
TYPE_REGISTRY.register({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Do we still need this? I don't see it changed for delegations or DIDs as well.
EDIT: I tried removing it and it did not break the integration tests.
EDIT 2: Nevermind, it broke the unit tests 😂
@@ -342,6 +342,23 @@ describe('handling queries to data not on chain', () => { | |||
}) | |||
}) | |||
|
|||
describe.only('hierarchyDetails', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
describe('hierarchyDetails', () => {
EDIT: I also tried removing .only
and of course all the rest of the delegation integration tests were also passing, so this can be removed safely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 I'll base the service endpoints PR on top of this and rebase it on develop
when this gets merged.
I’ve noticed that during upgrade many versions lost the |
@arty-name yes, that is correct. I tried with |
fixes KILTProtocol/ticket#1647
This PR updates the polkadot dependencies to work with the new 0.9.11 polkadot update.
I tried it out with a sample application, which connects to either peregrine stg, or spiritnet and I try to read a balance.
It works for both networks.
The type registry could be theoretically removed, but for downwards compatibility, we leave it in for the next release.
How to test:
Checklist: