Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CTypes to iterms #399

Merged
merged 2 commits into from
Jun 7, 2021
Merged

feat: CTypes to iterms #399

merged 2 commits into from
Jun 7, 2021

Conversation

Dudleyneedham
Copy link
Member

fixes https://github.com/KILTprotocol/ticket/issues/1374

Added an optional array ICType to ITerms interface.

How to test:

Please provide a brief step-by-step instruction.
If necessary provide information about dependencies (specific configuration, branches, database dumps, etc.)

  • Step 1
  • Step 2
  • etc.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@Dudleyneedham Dudleyneedham requested a review from tjwelde June 7, 2021 12:31
tjwelde
tjwelde approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@tjwelde tjwelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dudleyneedham Dudleyneedham requested a review from tjwelde June 7, 2021 13:06
tjwelde
tjwelde approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@tjwelde tjwelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM ;)

@Dudleyneedham Dudleyneedham merged commit a67fc24 into develop Jun 7, 2021
@Dudleyneedham Dudleyneedham deleted the dn-1374-add-ctype-to-iterms branch June 7, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjwelde tjwelde tjwelde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dudleyneedham @tjwelde