Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: createPresentation on AttestedClaim #398

Merged
merged 3 commits into from
Jun 4, 2021
Merged

feat: createPresentation on AttestedClaim #398

merged 3 commits into from
Jun 4, 2021

Conversation

rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Jun 4, 2021 •
edited
Loading

fixes KILTProtocol/ticket#1216

Removes Credential from the actors package and instead moves the createPresentation method to the AttestedClaim in core.
Deprecates removal of the claim owner - this produces unverifiable credentials because the owner public key is required for signature verification.

How to test:

unit tests have also been moved

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@rflechtner rflechtner force-pushed the remove-credential branch from 654e1ef to 6740de8 Compare June 4, 2021 15:09
tjwelde
tjwelde approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@tjwelde tjwelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rflechtner rflechtner merged commit 18d4df4 into develop Jun 4, 2021
@rflechtner rflechtner deleted the remove-credential branch June 4, 2021 16:02
@rflechtner rflechtner mentioned this pull request Jun 7, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjwelde tjwelde tjwelde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rflechtner @tjwelde