Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding balance locked, reserved and free #364

Merged
merged 10 commits into from
Apr 6, 2021

Conversation

Dudleyneedham
Copy link
Member

@Dudleyneedham Dudleyneedham commented Mar 31, 2021

fixes https://github.com/KILTprotocol/ticket/issues/1201

Adding locked, reserved and free balances.
Unable to add bonded, staked and vesting as pallets are not implemented.

How to test:

Run yarn test && yarn test:integration

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@Dudleyneedham Dudleyneedham requested a review from LeonFLK April 1, 2021 14:53
Copy link
Contributor

@LeonFLK LeonFLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should have tests that take into account the other Balances fields besides free?

Otherwise
LGTM

@LeonFLK LeonFLK self-requested a review April 1, 2021 15:29
@Dudleyneedham
Copy link
Member Author

At the moment, we don't have the pallets implemented in the node to actually test the different balances.

@Dudleyneedham Dudleyneedham merged commit 6f8d52f into develop Apr 6, 2021
@Dudleyneedham Dudleyneedham deleted the dn-1201-balance-types branch April 6, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants