Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export Blockchain utils #315

Merged
merged 4 commits into from
Dec 3, 2020
Merged

feat: export Blockchain utils #315

merged 4 commits into from
Dec 3, 2020

Conversation

tjwelde
Copy link
Contributor

@tjwelde tjwelde commented Dec 3, 2020

relates to KILTProtocol/ticket#167

This PR exports Blockchain functions via new namespace BlockchainUtils

How to test:

  • Tests should succeed

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@tjwelde tjwelde requested a review from LeonFLK December 3, 2020 15:55
@LeonFLK
Copy link
Contributor

LeonFLK commented Dec 3, 2020

Die Tests haben immer noch den alten import.

Copy link
Contributor

@LeonFLK LeonFLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need updated import fashion

Copy link
Contributor

@LeonFLK LeonFLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* @returns A promise which can be used to track transaction status.
* If resolved, this promise returns [[SubmittableResult]] that has led to its resolution.
*/
export async function submitTxWithReSign(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sehr nice, keine doppeltgemoppelte static method mehr.

@tjwelde tjwelde merged commit e48f1e2 into develop Dec 3, 2020
@tjwelde tjwelde deleted the tw-167-fix-export branch December 3, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants