Unit denomination and conversion #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dudleyneedham
pushed a commit
that referenced
this pull request
Sep 30, 2020
* feat: balance utils with conversion and formatting * feat: balance utils with conversion and formatting * test: updated formatBalance call and tests * test: remove deprecated GAS value * chore: add to index
Dudleyneedham
pushed a commit
that referenced
this pull request
Oct 5, 2020
* feat: balance utils with conversion and formatting * feat: balance utils with conversion and formatting * test: updated formatBalance call and tests * test: remove deprecated GAS value * chore: add to index
Dudleyneedham
pushed a commit
that referenced
this pull request
Oct 12, 2020
* feat: balance utils with conversion and formatting * feat: balance utils with conversion and formatting * test: updated formatBalance call and tests * test: remove deprecated GAS value * chore: add to index
Dudleyneedham
pushed a commit
that referenced
this pull request
Oct 12, 2020
* feat: balance utils with conversion and formatting * feat: balance utils with conversion and formatting * test: updated formatBalance call and tests * test: remove deprecated GAS value * chore: add to index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#632
Adds
Balance.utils.tsto the sdk to handle unit denomination and conversion in a central place instead of our separate components.How to test:
Create local instance, start demo client and services, add faucet and transfer funds to test if the portrayal of units is correct.
Checklist: