-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: generate diff between new and current runtime #549
Conversation
.gitlab-ci.yml
Outdated
@@ -72,6 +72,8 @@ build-wasm-peregrine: | |||
- cp -r * /build | |||
- /srtool/build build | |||
- subwasm meta --format=json+scale /out/peregrine_runtime.compact.wasm > /out/peregrine-metadata.json | |||
- subwasm get -o peregrine-live.wasm wss://peregrine.kilt.io | |||
- subwasm diff --no-color peregrine-live.wasm /out/peregrine_runtime.compact.wasm > /out/peregrine-diff.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the output is redirected to a file, and we don't expose it as an artifact. How can we use the result of the diff in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch i thought everything in out/
is an artifact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're saving it to a file, would it make more sense to have it in JSON format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about that as well. I think printing it to the output is not nice since it's harder to copy/past/store. During the release process you will download the artifacts anyways, so you will have this output there as well.
I personally can't process the JSON. I'm not sure if there are tools that use the JSON but I'm not aware of any. That's why I choose the text output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might also make sense to use tee
so that it's printed as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Next I was going to suggest to also print it. So maybe personally I would have printed the text version and stored the JSON version. But I am fine with having the text version stored as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could print it as well. Otherwise looks good!
fixes https://github.com/KILTprotocol/ticket/issues/2419
Describes the changes between the currently deployed spiritnet and peregrine runtimes.
I'm afraid we will only test this when it's merged on develop.
Example output: