feat: add tips pallet #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wischli
commented
Apr 6, 2022
runtimes/common/src/constants.rs
Outdated
| use super::*; | ||
|
|
||
| parameter_types! { | ||
| pub const DataDepositPerByte: Balance = deposit(0, 1); |
There was a problem hiding this comment.
In Polkadot, this is set to 1 cent. However, I wanted to align with our other deposits.
There was a problem hiding this comment.
We already have a constant ByteDeposit. Maybe we use this across all pallets that require a byte deposit? I'm not sure if there are cases where we want to have different byte deposits for different pallets.
wischli
commented
Apr 6, 2022
| pub const MaximumReasonLength: u32 = 16384; | ||
| pub const TipCountdown: BlockNumber = DAYS; | ||
| pub const TipFindersFee: Percent = Percent::from_percent(20); | ||
| pub const TipReportDepositBase: Balance = deposit(1, 1); |
There was a problem hiding this comment.
In Polkadot, this is set to 1 Dollar. However, I wanted to align with our other deposits.
wischli
commented
Apr 6, 2022
|
|
||
| parameter_types! { | ||
| pub const DataDepositPerByte: Balance = deposit(0, 1); | ||
| pub const MaximumReasonLength: u32 = 16384; |
There was a problem hiding this comment.
This is naively taken from Kusama configuration, I could not find any information where this value comes from unfortunately.
There was a problem hiding this comment.
I think we were told once that there is a threshold up to which a storage entry size doesn't influence the weights. If this threshold is passed, the storage needs to be taken into account when doing benchmarks. Maybe the value is related to that?
|
/bench runtime spiritnet-runtime pallet-tips |
|
Starting benchmark for branch: wf-add-tips-pallet (vs develop) Toolchain: Comment will be updated. |
|
/bench runtime spiritnet-runtime pallet-tips |
|
ERROR: Failed to query the currently active Rust toolchain |
|
/bench runtime spiritnet-runtime pallet-tips |
|
Benchmark Runtime Pallet for branch "wf-add-tips-pallet" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-tips --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_tips.rs --template=.maintain/runtime-weight-template.hbs ResultsERROR: Unable to commit file ./runtimes/spiritnet/src/weights/pallet_tips.rs |
weichweich
approved these changes
Apr 7, 2022
runtimes/peregrine/src/lib.rs
Outdated
| @@ -868,6 +905,9 @@ construct_runtime! { | |||
| // Preimage registrar | |||
| Preimage: pallet_preimage::{Pallet, Call, Storage, Event<T>} = 44, | |||
|
|
|||
| // Tips module. | |||
There was a problem hiding this comment.
The comment doesn't really explain more than the code already shows. Maybe we can add a one sentence description?
Suggested change
| // Tips module. | |
| // Tips module to reward contributions to the ecosystem with small amount of KILTs |
There was a problem hiding this comment.
Done in 31eaad3. I was wondering whether we rather want to add the tips pallet to the Governance block though. One argument against this would be to leave space for Governance 2.0.
weichweich
reviewed
Apr 7, 2022
runtimes/peregrine/src/lib.rs
Outdated
Comment on lines
478
to
481
| pub struct CouncilProvider; | ||
| impl frame_support::traits::SortedMembers<AccountId> for CouncilProvider { | ||
| fn contains(who: &AccountId) -> bool { | ||
| Council::is_member(who) |
There was a problem hiding this comment.
Forgot to attach this to the review. 🙄
I had the crazy idea that this could be generic and be part of the runtime common. But i'm not sure if that's possible.
There was a problem hiding this comment.
That would be the technical committee now. Right? Council would be one of the two pallet_membership instances?
There was a problem hiding this comment.
ah no! pallet_collective are the Council and Technical committe. pallet_membership is only technical committteee
There was a problem hiding this comment.
Yes, I think we eventually want to have the Council here as originally proposed by me.
There was a problem hiding this comment.
Ok I am finally happy with my changes from 31eaad3. I introduced a new instance of the membership pallet such that the Tippers are not tied to either the Council or the Technical Committee.
|
/bench runtime spiritnet-runtime pallet-tips |
wischli
commented
Apr 7, 2022
Comment on lines
+487
to
+488
| type MembershipInitialized = (); | ||
| type MembershipChanged = (); |
There was a problem hiding this comment.
These two receivers can be kept empty for Tippers IMO as we don't need to handle membership change anywhere else in contrast to the Technical Committee which also needs to apply it to the collective pallet.
|
/bench runtime spiritnet-runtime pallet-tips |
|
Benchmark Runtime Pallet for branch "wf-add-tips-pallet" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-tips --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_tips.rs --template=.maintain/runtime-weight-template.hbs Toolchain: nightly-2022-01-08-x86_64-unknown-linux-gnu (default) Results |
…hmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-tips --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_tips.rs --template=.maintain/runtime-weight-template.hbs
|
/bench runtime peregrine pallet-tips |
|
Benchmark Runtime Substrate Pallet for branch "wf-add-tips-pallet" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-tips --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_tips.rs --template=.maintain/runtime-weight-template.hbs Toolchain: nightly-2022-01-08-x86_64-unknown-linux-gnu (directory override for '/home/benchbot/bench-bot/git/mashnet-node') Results |
…hmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-tips --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_tips.rs --template=.maintain/runtime-weight-template.hbs
ntn-x2
reviewed
Apr 8, 2022
weichweich
approved these changes
Apr 19, 2022
ntn-x2
pushed a commit
that referenced
this pull request
Jun 23, 2022
* feat: add tips pallet * fix: benchmarks * refactor: move provider to common * feat: add tips membership pallet * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-tips --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_tips.rs --template=.maintain/runtime-weight-template.hbs * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-tips --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_tips.rs --template=.maintain/runtime-weight-template.hbs * refactor: apply suggestions from @ntn-x2 Co-authored-by: kiltbot <> (cherry picked from commit 9d318ee)
ntn-x2
added a commit
that referenced
this pull request
Jun 24, 2022
* Adds two more relaychain bootnodes for staging environment (#334) * chore: reset peregrine stg (#335) * ci: use custom ci image (#336) * Optimizes docker layer (#337) * fix: add did lookup pallet to DID authorization logic + reverse lookup index (#343) * chore: update toolchain version to nightly 1.59 (#339) * feat: proxy type for disableling deposit claiming (#341) * fix: rococo protocol id (#369) * feat: generic access control (#316) * Updates toolchain version (#345) * refactor: enforce no runtime in pallet (#349) * fix: features (#353) * feat: add tips pallet (#352) * feat: upgrade to Polkadot v0.9.19 (#357) * chore: upgrade and clean up (#360) * Adds the new rococo chainspec (#363) * feat: add launch pallet removal migration (#359) * refactor: update rilt para id from 2015 to 2108 (#364) * fix: rilt para id (#365) * feat: upgrade to Polkadot v0.9.23 (#366) * use ci-linx:production base image (#368) * feat: upgrade to Polkadot v0.9.24 (#370) * fix: fix CI builders compilation errors and pin to a specific hash (#372)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#1829
Todo
Checklist:
array[3]useget(3), ...)