Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: copying multiple attachments #961

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

JelleBoersma
Copy link
Contributor

@JelleBoersma JelleBoersma commented Apr 1, 2021

Copying multiple attachments using the part.copy() method caused the temporary directory to be removed.

Fixes #

Checklist:

  • My code follows the pykechain style
    • I added type hinting to all functions
    • I added documentation for all public functions
    • I locally used tox to check for dists and docs errors
    • My code passes the pep8 and flake8 linting checks and no warnings
    • I removed unused imports, using Code > Optimize Imports in PyCharm
    • I used black to format the new code
  • I have added tests that prove my fix is effective or that my feature works
    • I committed fresh test cassettes
    • I have proper test coverage (don't decline the coverage of the test)
  • I asked another teammate to review the code
  • I update the Changelog.md with the appropriate changes.

@JelleBoersma JelleBoersma self-assigned this Apr 1, 2021
@JelleBoersma JelleBoersma requested a review from jberends April 1, 2021 07:32
@JelleBoersma JelleBoersma merged commit 0702581 into master Apr 1, 2021
@JelleBoersma JelleBoersma deleted the copy_part_with_attachments branch April 1, 2021 08:10
jberends pushed a commit that referenced this pull request Nov 9, 2021
* Copying multiple attachments using the `part.copy()` method caused the temporary directory to be removed.

* Updated version to 3.10.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants