Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support-the-multi-attachmentviewer #1434

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Conversation

jberends
Copy link
Member

@jberends jberends commented Jun 4, 2024

Fixes #

Checklist:

  • My code follows the pykechain style
    • I added type hinting to all functions
    • I added documentation for all public functions
    • I locally used tox to check for dists and docs errors
    • My code passes the pep8 and flake8 linting checks and no warnings
    • I removed unused imports, using Code > Optimize Imports in PyCharm
    • I used black to format the new code
  • I have added tests that prove my fix is effective or that my feature works
    • I committed fresh test cassettes
    • I have proper test coverage (don't decline the coverage of the test)
  • I asked another teammate to review the code
  • I update the Changelog.md with the appropriate changes.

Updated Pykechain to include support for a new multi attachment viewer widget. This update includes changes to the widgets manager, the enums file, and the widget models file to accommodate the new widget type. Now, users can add and customize multi attachment viewer widgets in Pykechain with the provided methods.
@jberends jberends requested a review from raduiordache June 4, 2024 11:57
@jberends jberends self-assigned this Jun 4, 2024
Copy link
Contributor

@raduiordache raduiordache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the changelog and at least a small test. Although the test will have to be commented out since it will fail until we have that widget.

pykechain/models/widgets/widgets_manager.py Outdated Show resolved Hide resolved
jberends and others added 4 commits June 17, 2024 13:44
In this commit, a multiattachment viewer widget has been added to the codebase. This update is made to align with the KE-chain-2 backend. Additionally, dependent versions for development have been updated.
@jberends jberends merged commit 10a870c into main Jul 2, 2024
7 checks passed
@jberends jberends deleted the support-the-multi-attachmentviewer branch July 2, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants