Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 1340-support-columns-value to main #1341

Merged
merged 8 commits into from
Jul 6, 2023
Merged

Merge 1340-support-columns-value to main #1341

merged 8 commits into from
Jul 6, 2023

Conversation

raduiordache
Copy link
Contributor

@raduiordache raduiordache commented Jul 5, 2023 •
edited
Loading

…eReferenceProperty

Fixes #

Checklist:

  • My code follows the pykechain style
    • I added type hinting to all functions
    • I added documentation for all public functions
    • I locally used tox to check for dists and docs errors
    • My code passes the pep8 and flake8 linting checks and no warnings
    • I removed unused imports, using Code > Optimize Imports in PyCharm
    • I used black to format the new code
  • I have added tests that prove my fix is effective or that my feature works
    • I committed fresh test cassettes
    • I have proper test coverage (don't decline the coverage of the test)
  • I asked another teammate to review the code
  • I update the Changelog.md with the appropriate changes.

@raduiordache raduiordache linked an issue Jul 5, 2023 that may be closed by this pull request
Support 'columns' value_options for scope reference property #1340
Closed
jberends
jberends approved these changes Jul 6, 2023
View reviewed changes
pykechain/enums.py Show resolved Hide resolved
pykechain/models/property_reference.py Outdated Show resolved Hide resolved
tests/models/test_property_reference.py Outdated Show resolved Hide resolved
tests/models/test_property_reference.py Outdated Show resolved Hide resolved
@raduiordache raduiordache requested a review from jberends July 6, 2023 08:26
@raduiordache raduiordache self-assigned this Jul 6, 2023
@raduiordache raduiordache merged commit bc43f92 into main Jul 6, 2023
@raduiordache raduiordache deleted the 1340-support-columns-value_options-for-scope-reference-property branch July 6, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberends jberends jberends approved these changes

Assignees

@raduiordache raduiordache

Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support 'columns' value_options for scope reference property
2 participants
@raduiordache @jberends