Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1254 added a new API endpoint for ordering properties #1255

Merged
merged 4 commits into from
Jan 9, 2023

Conversation

raduiordache
Copy link
Contributor

@raduiordache raduiordache commented Jan 6, 2023

Fixes #

Checklist:

  • My code follows the pykechain style
    • I added type hinting to all functions
    • I added documentation for all public functions
    • I locally used tox to check for dists and docs errors
    • My code passes the pep8 and flake8 linting checks and no warnings
    • I removed unused imports, using Code > Optimize Imports in PyCharm
    • I used black to format the new code
  • I have added tests that prove my fix is effective or that my feature works
    • I committed fresh test cassettes
    • I have proper test coverage (don't decline the coverage of the test)
  • I asked another teammate to review the code
  • I update the Changelog.md with the appropriate changes.

@raduiordache raduiordache linked an issue Jan 9, 2023 that may be closed by this pull request
@jberends jberends enabled auto-merge (squash) January 9, 2023 11:11
@jberends jberends disabled auto-merge January 9, 2023 11:26
@jberends jberends merged commit c4aafa9 into main Jan 9, 2023
@jberends jberends deleted the 1254_reorder_properties branch January 9, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add new entrypoint for reorder properties functionality
2 participants