Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get the instances of a given model #113

Closed
thendrich opened this issue May 29, 2017 · 4 comments
Closed

Get the instances of a given model #113

thendrich opened this issue May 29, 2017 · 4 comments
Assignees
@jberends
Labels
agreed enhancement
Milestone
v1.8.0

Comments

@thendrich
Copy link

Similar to the some_part.instance.model() method but the other way around (result as a PartSet I guess)
@jberends
Copy link
Member

jberends commented May 31, 2017 •
edited
Loading 

bike_model.instances() == project.parts(model=bike_model) -> partSet with bike instances

@jberends jberends added enhancement RFC Request for comments labels May 31, 2017
@jberends jberends added this to the v1.8.0 milestone May 31, 2017
@jberends
Copy link
Member

This is in effect a duplicate of the project.parts(model=bike_model) call. The question is if we provide these kind of convenient methods.

@jberends jberends added agreed and removed RFC Request for comments labels Jun 4, 2017
@jberends
Copy link
Member

jberends commented Jun 4, 2017 •
edited
Loading

implemented in #123, slated for 1.8

@jberends jberends self-assigned this Jun 5, 2017
@jberends jberends mentioned this issue Jun 5, 2017
Merged
jberends added a commit that referenced this issue Jun 5, 2017
@jberends
Merge pull request #123 from KE-works/#118-instances-of-model
793bed8 
#113 added instances() and instance() method to the part
@jberends
Copy link
Member

jberends commented Jun 5, 2017

will be released in 1.8

@jberends jberends closed this as completed Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jberends jberends

Labels
agreed enhancement
Milestone
v1.8.0
Development

No branches or pull requests
2 participants
@jberends @thendrich