ForwardRenderer: allow rendering into QRenderTarget #92
Conversation
wheeland
force-pushed
the
render_into_qtexturetarget
branch
from
ae62ecf to
c6eee16
Compare
|
will be used in the materials demo that I'm preparing to render ground reflections. |
wheeland
force-pushed
the
render_into_qtexturetarget
branch
from
c6eee16 to
40e463c
Compare
wheeland
force-pushed
the
render_into_qtexturetarget
branch
from
40e463c to
4353152
Compare
| @@ -189,6 +195,18 @@ using namespace Kuesa; | |||
| Holds the size of the external render target. | |||
| */ | |||
|
|
|||
| /*! | |||
There was a problem hiding this comment.
Was this indented with Ctrl+E,R in QtCreator ?
There was a problem hiding this comment.
I just copied the formatting of the other property docs
| */ | ||
| void ForwardRenderer::setRenderTarget(Qt3DRender::QRenderTarget *renderTarget) | ||
| { | ||
| m_renderTargetSelector->setTarget(renderTarget); |
There was a problem hiding this comment.
shouldn't we rebuild the FrameGraph if we had previously set a window ?
There was a problem hiding this comment.
m_renderTargetSelector::targetChanged is connected to reconfigureFrameGraph() and handleSurfaceChange()
| else | ||
| qCWarning(kuesa) << Q_FUNC_INFO << "Unexpected surface type for surface " << surface; | ||
| if (renderTarget) { | ||
| Qt3DRender::QAbstractTexture *texture = findRenderTargetTexture(renderTarget, Qt3DRender::QRenderTargetOutput::Color0); |
There was a problem hiding this comment.
What happens if the render target doesn't have the Color0 attachment?
There was a problem hiding this comment.
Changed the patch so that in that case it falls back to rendering to a surface (if any is given)
wheeland
force-pushed
the
render_into_qtexturetarget
branch
from
c02f46d to
1b9eca9
Compare
|
Added an auto test in addition the the manual test. This now tries to fall back to surface rendering and prints a warning. |
No description provided.