Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjustments to objdump call #535

Merged
merged 3 commits into from
Oct 30, 2023
Merged

adjustments to objdump call #535

merged 3 commits into from
Oct 30, 2023

Conversation

GitMensch
Copy link
Contributor

@GitMensch GitMensch commented Oct 22, 2023

After recognizing that the process path of objdump is resolved first, I've adjusted the PR to use that (so the additional stat calls seen in #527 are not needed).

  • invoke directly from the processPath already resolved before
  • improve error message for objdump invocation issues helping to find problems related to the call

@GitMensch GitMensch force-pushed the patch-2 branch 2 times, most recently from 8627b70 to 75a6cfa Compare October 22, 2023 19:44
@GitMensch GitMensch changed the title improve error message for objdump invocation issues adjustments to objdump call Oct 22, 2023
@lievenhey
Copy link
Contributor

@GitMensch lgtm, but can you ran clang-format so that the ci no longer complains?

@GitMensch
Copy link
Contributor Author

applied clang-format -i and pushed

src/models/disassemblyoutput.cpp Outdated Show resolved Hide resolved
src/models/disassemblyoutput.cpp Outdated Show resolved Hide resolved
@GitMensch
Copy link
Contributor Author

  • string puzzle fixed, other invocations of error messages changed accordingly
  • additional commit fixing a related issue (missing check -> error message)

@GitMensch GitMensch requested a review from milianw October 29, 2023 16:53
src/models/disassemblyoutput.cpp Show resolved Hide resolved
src/models/disassemblyoutput.cpp Show resolved Hide resolved
src/models/disassemblyoutput.cpp Show resolved Hide resolved
invoke directly from the processPath  already resolved before
* comon formatting
* always showing the problem details
@GitMensch
Copy link
Contributor Author

rebased and split from 2 to 3 separate commits (I do like the result more than the original, too); tested manually in the GUI using the files under "tests" (all but the timeout, checked this with the appImage and also works as expected).

Adjusted one test as needed and added some of the missing tests for the adjusted messages.

@GitMensch GitMensch requested a review from milianw October 30, 2023 19:15
@milianw milianw merged commit e8ec1c0 into KDAB:master Oct 30, 2023
11 of 12 checks passed
@milianw
Copy link
Member

milianw commented Oct 30, 2023

thanks!

@GitMensch GitMensch deleted the patch-2 branch October 30, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants