-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjustments to objdump call #535
Conversation
8627b70
to
75a6cfa
Compare
@GitMensch lgtm, but can you ran |
applied |
|
invoke directly from the processPath already resolved before
fixing view part of KDAB#536
* comon formatting * always showing the problem details
rebased and split from 2 to 3 separate commits (I do like the result more than the original, too); tested manually in the GUI using the files under "tests" (all but the timeout, checked this with the appImage and also works as expected). Adjusted one test as needed and added some of the missing tests for the adjusted messages. |
thanks! |
After recognizing that the process path of objdump is resolved first, I've adjusted the PR to use that (so the additional
stat
calls seen in #527 are not needed).