New elevate system #493
Merged
New elevate system #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lievenhey
force-pushed
the
new-elevate-system
branch
from
e9c8a8f to
7bc7972
Compare
lievenhey
commented
Jun 30, 2023
milianw
requested changes
Jul 7, 2023
lievenhey
force-pushed
the
new-elevate-system
branch
from
7bc7972 to
3e4ed03
Compare
milianw
force-pushed
the
new-elevate-system
branch
from
3e4ed03 to
e0caf9e
Compare
For running perf with pkexec we need to get the full path to the binary, so handle this consistently. This has the nice side effect of showing clearly which perf binary is being used in the output console.
The new previlige handling will call perf directly without a helper, so KAuth does not make sense for that anymore.
Instead of using a script that changes system configuration temporarily, just run perf as root. To properly synchronize with a launched app (that itself should not run as root), launch the app in a separate, initially stopped process, and use the control fifo feature of perf to properly synchronize with it. The control fifos are also needed to be able to stop sudo-perf, as one does not have permission to SIGINT it anymore.
The new elevation system is not prone to the security issues of the old system, as such we no longer need to have users opt-in to this functionality anymore.
We now always use pkexec, so we shouldn't even mention kdesu/kdesudo anywhere.
milianw
force-pushed
the
new-elevate-system
branch
from
e0caf9e to
357cfec
Compare
milianw
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the original pr by @zeno-endemann-kdab but I can't edit the original, so I had to recreate it.