-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perfdata added to file open list #443
Conversation
e506636
to
e71072c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please reword your commit message, it's pretty confusing. it would be better to clearly state that you are adding the *.perfdata
pattern to the file open filter list
aee5993
to
da99dd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm, let's wait for the CI and then this can be merged
Argh sorry, it cannot be const b/c we need to pass |
along with a group that includes the pattern and moving out to a separate function again
along with a group that includes it and moving out to a separate function again
fixing the side issue mentioned in #440