Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perfdata added to file open list #443

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Conversation

GitMensch
Copy link
Contributor

along with a group that includes it and moving out to a separate function again

fixing the side issue mentioned in #440

@GitMensch GitMensch marked this pull request as draft December 3, 2022 16:06
@GitMensch GitMensch force-pushed the perfdata branch 5 times, most recently from e506636 to e71072c Compare December 3, 2022 16:47
@GitMensch GitMensch marked this pull request as ready for review December 3, 2022 16:48
Copy link
Member

@milianw milianw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please reword your commit message, it's pretty confusing. it would be better to clearly state that you are adding the *.perfdata pattern to the file open filter list

src/mainwindow.cpp Outdated Show resolved Hide resolved
src/mainwindow.cpp Outdated Show resolved Hide resolved
@GitMensch GitMensch force-pushed the perfdata branch 3 times, most recently from aee5993 to da99dd0 Compare December 3, 2022 20:26
src/mainwindow.cpp Outdated Show resolved Hide resolved
Copy link
Member

@milianw milianw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, let's wait for the CI and then this can be merged

@milianw
Copy link
Member

milianw commented Dec 3, 2022

Argh sorry, it cannot be const b/c we need to pass this as a non-const QWidget * parent... sorry please remove the const again!

.gitpod.yml Outdated Show resolved Hide resolved
along with a group that includes the pattern and moving out to a separate function again
@milianw milianw merged commit fc2fb9a into KDAB:master Dec 4, 2022
@GitMensch GitMensch deleted the perfdata branch December 4, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants