Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recognize perfparser format (peek into file on open) #477

Closed
GitMensch opened this issue Mar 24, 2023 · 1 comment · Fixed by #539
Closed

recognize perfparser format (peek into file on open) #477

GitMensch opened this issue Mar 24, 2023 · 1 comment · Fixed by #539
Labels
enhancement

Comments

@GitMensch
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When naming a file something.perfparser (or even"banana") opening the file via hotspot does not work "The hotspot-perfparser binary existed with code 4 (invalid perf data file)."

Describe the solution you'd like
peek into the file specified at command line or via open dialog

Describe alternatives you've considered
Always remember to name the file correctly...
@GitMensch
Copy link
Contributor Author

Rechecked now: we can check for perfparser file easily by inspecting the first bytes:

$> xxd -l 12 my.perfparser
00000000: 5150 4552 4653 5452 4541 4d00            QPERFSTREAM.

I have a look at implementing that using QFile.open()->peek(11) == 'QPERFSTREAM'.

GitMensch added a commit to GitMensch/hotspot that referenced this issue Oct 24, 2023
@GitMensch
peek into file before open
9cbfeba 
* check file open, providing nice and early error
* explicit check for perfparser (magic number QPERFSTREAM)
  opening directly without the need to fall back to file name
* explicit check for V1 perf data which isn't supported by perfparser
* explicit check for unknown file type

Fixes: KDAB#477
@GitMensch GitMensch mentioned this issue Oct 24, 2023
Merged
GitMensch added a commit to GitMensch/hotspot that referenced this issue Oct 24, 2023
@GitMensch
peek into file before open
0cd2937 
* check file open, providing nice and early error
* explicit check for perfparser (magic number QPERFSTREAM)
  opening directly without the need to fall back to file name
* explicit check for V1 perf data which isn't supported by perfparser
* explicit check for unknown file type

Fixes: KDAB#477
GitMensch added a commit to GitMensch/hotspot that referenced this issue Oct 30, 2023
@GitMensch
peek into file before open
c84542c 
* check file open, providing nice and early error
* explicit check for perfparser (magic number QPERFSTREAM)
  opening directly without the need to fall back to file name
* explicit check for V1 perf data which isn't supported by perfparser
* explicit check for unknown file type

Fixes: KDAB#477
GitMensch added a commit to GitMensch/hotspot that referenced this issue Nov 1, 2023
@GitMensch
peek into file before open
eaeff1f 
* check file open, providing nice and early error
* explicit check for perfparser (magic number QPERFSTREAM)
  opening directly without the need to fall back to file name
* explicit check for V1 perf data which isn't supported by perfparser
* explicit check for unknown file type

Fixes: KDAB#477
GitMensch added a commit to GitMensch/hotspot that referenced this issue Nov 1, 2023
@GitMensch
peek into file before open
1f5e434 
* check file open, providing nice and early error
* explicit check for perfparser (magic number QPERFSTREAM)
  opening directly without the need to fall back to file name
* explicit check for V1 perf data which isn't supported by perfparser
* explicit check for unknown file type

Fixes: KDAB#477
GitMensch added a commit to GitMensch/hotspot that referenced this issue Nov 1, 2023
@GitMensch
peek into file before open
f41fe8e 
* check file open, providing nice and early error
* explicit check for perfparser (magic number QPERFSTREAM)
  opening directly without the need to fall back to file name
* explicit check for V1 perf data which isn't supported by perfparser
* explicit check for unknown file type

Fixes: KDAB#477
GitMensch added a commit to GitMensch/hotspot that referenced this issue Nov 3, 2023
@GitMensch
peek into file before open
7fccf85 
* check file open, providing nice and early error
* explicit check for perfparser (magic number QPERFSTREAM)
  opening directly without the need to fall back to file name
* explicit check for V1 perf data which isn't supported by perfparser
* explicit check for unknown file type

Fixes: KDAB#477
GitMensch added a commit to GitMensch/hotspot that referenced this issue Nov 3, 2023
@GitMensch
peek into file before open
4ffef0b 
* check file open, providing nice and early error
* explicit check for perfparser (magic number QPERFSTREAM)
  opening directly without the need to fall back to file name
* explicit check for V1 perf data which isn't supported by perfparser
* explicit check for unknown file type

Fixes: KDAB#477
GitMensch added a commit to GitMensch/hotspot that referenced this issue Nov 5, 2023
@GitMensch
peek into file before open
c420b6b 
* check file open, providing nice and early error
* explicit check for perfparser (magic number QPERFSTREAM)
  opening directly without the need to fall back to file name
* explicit check for V1 perf data which isn't supported by perfparser
* explicit check for unknown file type

fixes KDAB#477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

peek into file before open GitMensch/hotspot
1 participant
@GitMensch